Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_url: remove deprecated sha256sum module param #77408

Merged
merged 2 commits into from
Apr 1, 2022
Merged

get_url: remove deprecated sha256sum module param #77408

merged 2 commits into from
Apr 1, 2022

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Mar 30, 2022

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/get_url.py

@ansibot ansibot added affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 30, 2022
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2022
jborean93
jborean93 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requires the merge conflict to be resolved.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 31, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 1, 2022
@mkrizek mkrizek merged commit f933f9a into ansible:devel Apr 1, 2022
@mkrizek mkrizek deleted the get_url-sha256sum branch April 1, 2022 08:26
@ansible ansible locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkrizek @jborean93 @ansibot