Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uri, urn and url test plugins #77423

Merged
merged 33 commits into from May 25, 2022
Merged

Add uri, urn and url test plugins #77423

merged 33 commits into from May 25, 2022

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 30, 2022

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tests/url.py

@ansibot ansibot added affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2022
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2022
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2022
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 8, 2022
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 17, 2022
@samccann
Copy link
Contributor

Docs portion LGTM

felixfontein
felixfontein reviewed May 19, 2022
View reviewed changes
lib/ansible/plugins/test/uri.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/uri.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/uri.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/url.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/url.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/url.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/url.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/urn.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/test/urn.yml Outdated Show resolved Hide resolved
changelogs/fragments/added_uri_tests.yml Show resolved Hide resolved
bcoca and others added 9 commits May 19, 2022 14:54
@bcoca @felixfontein
Update lib/ansible/plugins/test/uri.yml
a3624d1 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/uri.yml
286cb54 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/uri.yml
0008d2b 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/url.yml
f699a11 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/url.yml
8ca44df 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/url.yml
236a504 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/urn.yml
cdfc8ff 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/urn.yml
1f168f7 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/url.yml
a2b5a39 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels May 19, 2022
@felixfontein
Copy link
Contributor

@bcoca there are 10 suggestions of mine hidden automatically by GH which you didn't respond to yet. Also I'm curious why you resolved the last comment without any comment or change.

@Dule-martins
Copy link
Contributor

@felixfontein

The last come LGTM, what do you think?

@felixfontein
Copy link
Contributor

@Dule-mart I'm not sure what you mean.

@bcoca
Copy link
Member Author

bcoca commented May 23, 2022

@felixfontein i had merged most, ignored the changelog one as we still wanted it

bcoca and others added 7 commits May 24, 2022 15:50
@bcoca @felixfontein
Update lib/ansible/plugins/test/uri.yml
4e7548d 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/uri.yml
8c476de 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/url.yml
149de31 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/url.yml
6781054 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/urn.yml
01ec12c 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/plugins/test/urn.yml
f34650a 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Apply suggestions from code review
5271a79 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca bcoca merged commit f7d7604 into ansible:devel May 25, 2022
@bcoca bcoca deleted the uri_tests branch May 25, 2022 14:34
@ansible ansible locked and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dule-martins Dule-martins Dule-martins requested changes

@felixfontein felixfontein felixfontein approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.14 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bcoca @ansibot @samccann @felixfontein @Dule-martins @jborean93