Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for ansible-galaxy server config definitions #77424

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

s-hertel
Copy link
Contributor

SUMMARY

The server config didn't define type, so it was implicitly 'str' for all options. This fixes the boolean options that were truthy when set to False.

Fixes #77416

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 30, 2022
@s-hertel s-hertel force-pushed the fix_server_specific_validate_certs branch from 6665af0 to fcec113 Compare March 30, 2022 23:55
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2022
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2022
@jborean93 jborean93 merged commit 87a8fed into ansible:devel Mar 31, 2022
@ansible ansible locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

galaxy validate_certs remains a stringt type instead of typecast to bool
3 participants