Extend systemctl is-enabled check to handle "enabled-runtime" too. #77754
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.14
bug
bcoca
requested changes
May 9, 2022
ansibot
added
needs_revision
s-hertel
removed
the
needs_triage
ansibot
added
needs_rebase
ansibot
removed
the
new_contributor
In general the existence of a runtime-enabled unit should not prevent a persistent enable being set. Specifically this handles the case where there is an entry in fstab for a mountpoint (which is retained to allow manual mount/umount to take place) and yet a systemd mount unit needs to be deployed to handle other unit options. There will be a generator-created unit file which shows the unit as enabled-runtime and the persistent enable of the mount unit will fail. Additionally improve the comments and modify the code to use rsplit() and the "in" notation since "systemctl is-enabled" is documented to return specific values in the cases of interest. Signed-off-by: David Greaves <david@dgreaves.com>
* added changelog
Akasurde
force-pushed
the
extend-systemd-enabled-checking
branch
from
088bb46
to
10fe45c
Compare
ansibot
added
stale_review
bcoca
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In general the existence of a runtime-enabled unit should not prevent a persistent enable being set.
Specifically this handles the case where there is an entry in fstab
for a mountpoint (which is retained to allow manual mount/umount to
take place) and yet a systemd mount unit needs to be deployed to
handle other unit options. There will be a generator-created unit file
which shows the unit as enabled-runtime and the persistent enable of
the mount unit will fail.
Additionally improve the comments and modify the code to use rsplit()
and the "in" notation since "systemctl is-enabled" is documented to
return specific values in the cases of interest.
ISSUE TYPE
COMPONENT NAME
ansible.builtin.systemd
ADDITIONAL INFORMATION