Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate meta/main.yml dependencies and meta/requirements.yml are lists #77821

Merged
merged 1 commit into from May 19, 2022

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Fix an unhandled traceback and give a clear error when installing roles dependencies that are in collection + role requirement file format, e.g.

collections:
  - ns.coll
roles:
  - role

This matches role runtime behavior for meta/main.yml dependencies which must be a list of roles.

Alternative approach to #73480, which adds support for that format with a warning if collections key is provided.
Closes #73480

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 17, 2022
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label May 19, 2022
@mattclay mattclay merged commit 400475a into ansible:devel May 19, 2022
@sivel sivel mentioned this pull request May 25, 2022
1 task
@ansible ansible locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants