New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.13] Fix ansible-galaxy traceback when unexpected version of resolvelib is installed #77901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… installed (ansible#77630) * Fix traceback when a supported version of resolvelib is not installed Try to read the supported version range from the package distribution info and fall back to a hardcoded lowerbound/upperbound (>=0.5.3,<0.6.0). * Add tests for unsupported resolvelib versions * Resolve remaining import sanity test issues. Co-authored-by: Matt Clay <matt@mystile.com> Co-authored-by: Matt Martz <matt@sivel.net> (cherry picked from commit 82f3a57)
ansibot
added
affects_2.13
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
labels
May 24, 2022
This should only be merged once #77906 or something similal has been merged and included here. |
… when a valid resolvelib is installed. (ansible#77906) (cherry picked from commit 6fbc8bd)
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Jun 2, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
removed
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Jun 7, 2022
s-hertel
commented
Jun 7, 2022
ansibot
added
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Jun 7, 2022
…g the ansible-core distribution (ansible#77993) (cherry picked from commit db33549)
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
labels
Jun 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.13
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport #77630
Try to read the supported version range from the package distribution info and fall back to a hardcoded lowerbound/upperbound (>=0.5.3,<0.6.0).
Add tests for unsupported resolvelib versions
Resolve remaining import sanity test issues.
Co-authored-by: Matt Clay matt@mystile.com
Co-authored-by: Matt Martz matt@sivel.net
(cherry picked from commit 82f3a57)
(cherry picked from commit db33549)
ISSUE TYPE
COMPONENT NAME
ansible-galaxy