Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] Fix ansible-galaxy traceback when unexpected version of resolvelib is installed #77901

Merged
merged 3 commits into from Jun 9, 2022

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented May 24, 2022

SUMMARY

Backport #77630

  • Fix traceback when a supported version of resolvelib is not installed

Try to read the supported version range from the package distribution info and fall back to a hardcoded lowerbound/upperbound (>=0.5.3,<0.6.0).

  • Add tests for unsupported resolvelib versions

  • Resolve remaining import sanity test issues.

Co-authored-by: Matt Clay matt@mystile.com
Co-authored-by: Matt Martz matt@sivel.net
(cherry picked from commit 82f3a57)
(cherry picked from commit db33549)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

… installed (ansible#77630)

* Fix traceback when a supported version of resolvelib is not installed

Try to read the supported version range from the package distribution info and fall back to a hardcoded lowerbound/upperbound (>=0.5.3,<0.6.0).

* Add tests for unsupported resolvelib versions

* Resolve remaining import sanity test issues.

Co-authored-by: Matt Clay <matt@mystile.com>
Co-authored-by: Matt Martz <matt@sivel.net>
(cherry picked from commit 82f3a57)
@ansibot ansibot added affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 24, 2022
@felixfontein
Copy link
Contributor

This should only be merged once #77906 or something similal has been merged and included here.

… when a valid resolvelib is installed. (ansible#77906)

(cherry picked from commit 6fbc8bd)
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 2, 2022
@sivel
Copy link
Member

sivel commented Jun 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 7, 2022
@s-hertel s-hertel marked this pull request as draft June 7, 2022 20:54
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 7, 2022
…g the ansible-core distribution (ansible#77993)

(cherry picked from commit db33549)
@s-hertel s-hertel marked this pull request as ready for review June 8, 2022 16:07
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jun 8, 2022
@sivel sivel merged commit 977c248 into ansible:stable-2.13 Jun 9, 2022
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 9, 2022
@ansible ansible locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants