New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable-2.13] Update mypy test. Fix type hints for Python 3.9. #78587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also bumps the minimum controller version (for mypy only) to Python 3.9. (cherry picked from commit cc5ac88)
ansibot
added
affects_2.13
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Aug 18, 2022
The failures seem to be related to https://progress.opensuse.org/issues/115508. |
Log, for history: 26:21 "stdout_lines": [
26:21 "<?xml version='1.0'?>",
26:21 "<stream>",
26:21 "<message type=\"error\">Repository 'Update repository of openSUSE Backports' is invalid.",
26:21 "[repo-backports-update|http://download.opensuse.org/update/leap/15.3/backports/] Valid metadata not found at specified URL",
26:21 "History:",
26:21 " - [|] Error trying to read from '[http://download.opensuse.org/update/leap/15.3/backports/'",](http://download.opensuse.org/update/leap/15.3/backports/'%22,)
26:21 " - Timeout exceeded when accessing '[http://download.opensuse.org/update/leap/15.3/backports/content'.",](http://download.opensuse.org/update/leap/15.3/backports/content'.%22,)
26:21 "",
26:21 "Please check if the URIs defined for this repository are pointing to a valid repository.",
26:21 "</message>",
26:21 "<message type=\"warning\">Skipping repository 'Update repository of openSUSE Backports' because of the above error.</message>",
26:21 "<message type=\"error\">Repository 'Non-OSS Repository' is invalid.",
26:21 "[repo-non-oss|http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/] Valid metadata not found at specified URL",
26:21 "History:",
26:21 " - [|] Error trying to read from '[http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/'",](http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/'%22,)
26:21 " - Timeout exceeded when accessing '[http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/content'.",](http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/content'.%22,)
26:21 "",
26:21 "Please check if the URIs defined for this repository are pointing to a valid repository.",
26:21 "</message>",
26:21 "<message type=\"warning\">Skipping repository 'Non-OSS Repository' because of the above error.</message>",
26:21 "<message type=\"error\">Repository 'Main Repository' is invalid.",
26:21 "[repo-oss|http://download.opensuse.org/distribution/leap/15.3/repo/oss/] Valid metadata not found at specified URL",
26:21 "History:",
26:21 " - [|] Error trying to read from '[http://download.opensuse.org/distribution/leap/15.3/repo/oss/'",](http://download.opensuse.org/distribution/leap/15.3/repo/oss/'%22,)
26:21 " - Timeout exceeded when accessing '[http://download.opensuse.org/distribution/leap/15.3/repo/oss/content'.",](http://download.opensuse.org/distribution/leap/15.3/repo/oss/content'.%22,)
26:21 "",
26:21 "Please check if the URIs defined for this repository are pointing to a valid repository.",
26:21 "</message>",
26:21 "<message type=\"warning\">Skipping repository 'Main Repository' because of the above error.</message>",
26:21 "<message type=\"error\">Repository 'Update repository with updates from SUSE Linux Enterprise 15' is invalid.",
26:21 "[repo-sle-update|http://download.opensuse.org/update/leap/15.3/sle/] Valid metadata not found at specified URL",
26:21 "<message type=\"error\">Package '+krb5-client' not found.</message>",
26:21 "<message type=\"error\">Package '+krb5-devel' not found.</message>",
26:21 "</stream>"
26:21 ] |
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Aug 19, 2022
sivel
removed
the
needs_triage
Needs a first human triage before being processed.
label
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.13
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport of #77726
Update mypy test. Fix type hints for Python 3.9.
This also bumps the minimum controller version (for mypy only) to Python 3.9.
(cherry picked from commit cc5ac88)
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ansible-test
ADDITIONAL INFORMATION
Making Python 3.9 the minimum controller version for mypy avoids having to fix all the Python 3.8 issues with existing type hints. They're not worth fixing just for this branch.