Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.13] Update mypy test. Fix type hints for Python 3.9. #78587

Merged
merged 1 commit into from Aug 19, 2022

Conversation

mattclay
Copy link
Member

SUMMARY

Backport of #77726

Update mypy test. Fix type hints for Python 3.9.

This also bumps the minimum controller version (for mypy only) to Python 3.9.

(cherry picked from commit cc5ac88)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible-test

ADDITIONAL INFORMATION

Making Python 3.9 the minimum controller version for mypy avoids having to fix all the Python 3.8 issues with existing type hints. They're not worth fixing just for this branch.

This also bumps the minimum controller version (for mypy only) to Python 3.9.

(cherry picked from commit cc5ac88)
@ansibot ansibot added affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 18, 2022
@webknjaz
Copy link
Member

The failures seem to be related to https://progress.opensuse.org/issues/115508.

@webknjaz
Copy link
Member

Log, for history:

26:21     "stdout_lines": [
26:21         "<?xml version='1.0'?>",
26:21         "<stream>",
26:21         "<message type=\"error\">Repository &apos;Update repository of openSUSE Backports&apos; is invalid.",
26:21         "[repo-backports-update|http://download.opensuse.org/update/leap/15.3/backports/] Valid metadata not found at specified URL",
26:21         "History:",
26:21         " - [|] Error trying to read from &apos;[http://download.opensuse.org/update/leap/15.3/backports/&apos;",](http://download.opensuse.org/update/leap/15.3/backports/&apos;%22,)
26:21         " - Timeout exceeded when accessing &apos;[http://download.opensuse.org/update/leap/15.3/backports/content&apos;.",](http://download.opensuse.org/update/leap/15.3/backports/content&apos;.%22,)
26:21         "",
26:21         "Please check if the URIs defined for this repository are pointing to a valid repository.",
26:21         "</message>",
26:21         "<message type=\"warning\">Skipping repository &apos;Update repository of openSUSE Backports&apos; because of the above error.</message>",
26:21         "<message type=\"error\">Repository &apos;Non-OSS Repository&apos; is invalid.",
26:21         "[repo-non-oss|http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/] Valid metadata not found at specified URL",
26:21         "History:",
26:21         " - [|] Error trying to read from &apos;[http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/&apos;",](http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/&apos;%22,)
26:21         " - Timeout exceeded when accessing &apos;[http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/content&apos;.",](http://download.opensuse.org/distribution/leap/15.3/repo/non-oss/content&apos;.%22,)
26:21         "",
26:21         "Please check if the URIs defined for this repository are pointing to a valid repository.",
26:21         "</message>",
26:21         "<message type=\"warning\">Skipping repository &apos;Non-OSS Repository&apos; because of the above error.</message>",
26:21         "<message type=\"error\">Repository &apos;Main Repository&apos; is invalid.",
26:21         "[repo-oss|http://download.opensuse.org/distribution/leap/15.3/repo/oss/] Valid metadata not found at specified URL",
26:21         "History:",
26:21         " - [|] Error trying to read from &apos;[http://download.opensuse.org/distribution/leap/15.3/repo/oss/&apos;",](http://download.opensuse.org/distribution/leap/15.3/repo/oss/&apos;%22,)
26:21         " - Timeout exceeded when accessing &apos;[http://download.opensuse.org/distribution/leap/15.3/repo/oss/content&apos;.",](http://download.opensuse.org/distribution/leap/15.3/repo/oss/content&apos;.%22,)
26:21         "",
26:21         "Please check if the URIs defined for this repository are pointing to a valid repository.",
26:21         "</message>",
26:21         "<message type=\"warning\">Skipping repository &apos;Main Repository&apos; because of the above error.</message>",
26:21         "<message type=\"error\">Repository &apos;Update repository with updates from SUSE Linux Enterprise 15&apos; is invalid.",
26:21         "[repo-sle-update|http://download.opensuse.org/update/leap/15.3/sle/] Valid metadata not found at specified URL",
26:21         "<message type=\"error\">Package &apos;+krb5-client&apos; not found.</message>",
26:21         "<message type=\"error\">Package &apos;+krb5-devel&apos; not found.</message>",
26:21         "</stream>"
26:21     ]

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 19, 2022
@nitzmahone nitzmahone merged commit fd19350 into ansible:stable-2.13 Aug 19, 2022
@mattclay mattclay deleted the mypy-2.13 branch August 19, 2022 17:51
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 22, 2022
@ansible ansible locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants