Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][2.13] Fail fast in stuck ansible-galaxy-collection #78627

Conversation

webknjaz
Copy link
Member

SUMMARY

This specific integration test gets stuck periodically causing the
Galaxy jobs to be killed on timeout wasting an hour of runtime. The
module that gets stuck waiting on Pulp is an in-test one, called
setup_collections. When it works, the task is complete in around 70
seconds but when it doesn't, it just freezes the whole play.

This patch attempts to make it fail faster by putting a reasonable
timeout value of 2 minutes.

(cherry picked from commit f1c56e9)

This is a backport of #78616

ISSUE TYPE
  • Maintenance Pull Request
  • Test Pull Request
COMPONENT NAME

test/integration/targets/ansible-galaxy-collection/library/setup_collections.py

ADDITIONAL INFORMATION

N/A

This specific integration test gets stuck periodically causing the
Galaxy jobs to be killed on timeout wasting an hour of runtime. The
module that gets stuck waiting on Pulp is an in-test one, called
`setup_collections`. When it works, the task is complete in around 70
seconds but when it doesn't, it just freezes the whole play.

This patch attempts to make it fail faster by putting a reasonable
timeout value of 2 minutes.

(cherry picked from commit f1c56e9)
@ansibot ansibot added affects_2.13 backport This PR does not target the devel branch. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 23, 2022
@webknjaz
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@webknjaz webknjaz requested a review from mattclay August 31, 2022 12:32
@sivel sivel merged commit 47d34ce into ansible:stable-2.13 Aug 31, 2022
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 1, 2022
@ansible ansible locked and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 backport This PR does not target the devel branch. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants