Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.13] Limit Galaxy API calls during ansible-galaxy dependency resolution #78722

Merged
merged 1 commit into from Sep 28, 2022
Merged

[2.13] Limit Galaxy API calls during ansible-galaxy dependency resolution #78722

merged 1 commit into from Sep 28, 2022

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Sep 6, 2022

SUMMARY

Backport for #77468

  • Limit Galaxy API calls during ansible-galaxy collection dependency resolution when possible

Installing a tarfile with a dependency from a Galaxy server (e.g. dependencies: {'ns.coll': '>=1.0.0'}) does not get the available versions of the dependency from the galaxy server if a sufficient version is already installed.

Co-authored-by: Sviatoslav Sydorenko wk.cvs.github@sydorenko.org.ua
(cherry picked from commit 41b62f7)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

@s-hertel
Limit Galaxy API calls during ansible-galaxy dependency resolution (a…
fee4c92 
…nsible#77468)

* Limit Galaxy API calls during ansible-galaxy collection dependency resolution when possible

Installing a tarfile with a dependency from a Galaxy server (e.g. dependencies: {'ns.coll': '>=1.0.0'}) does not get the available versions of the dependency from the galaxy server if a sufficient version is already installed.

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 41b62f7)
@ansibot ansibot added affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 6, 2022
@webknjaz
Copy link
Member

webknjaz commented Sep 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 15, 2022
@sivel
Copy link
Member

sivel commented Sep 28, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 28, 2022
@sivel sivel merged commit 551ddeb into ansible:stable-2.13 Sep 28, 2022
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 4, 2022
@ansible ansible locked and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s-hertel @webknjaz @sivel @ansibot