Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documented windows filters #78876

Merged
merged 4 commits into from Sep 27, 2022
Merged

documented windows filters #78876

merged 4 commits into from Sep 27, 2022

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Sep 26, 2022

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

filters

@ansibot ansibot added affects_2.15 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 26, 2022
felixfontein
felixfontein reviewed Sep 26, 2022
View reviewed changes
lib/ansible/plugins/filter/win_basename.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_dirname.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_splitdrive.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_splitdrive.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_splitdrive.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_dirname.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_dirname.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Contributor

A rendered version of the current PR's state can be seen here:

@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 27, 2022
@bcoca @felixfontein
Apply suggestions from code review
ebe9ed7 
Co-authored-by: Felix Fontein <felix@fontein.de>
samccann
samccann reviewed Sep 27, 2022
View reviewed changes
lib/ansible/plugins/filter/win_basename.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_dirname.yml Outdated Show resolved Hide resolved
lib/ansible/plugins/filter/win_splitdrive.yml Outdated Show resolved Hide resolved
@bcoca bcoca merged commit 7c4d5f5 into ansible:devel Sep 27, 2022
@bcoca bcoca deleted the winfilters branch September 27, 2022 16:14
bcoca added a commit to bcoca/ansible that referenced this pull request Sep 27, 2022
@bcoca
documented windows filters (ansible#78876)
82dd7fb 
* documented windows filters

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 7c4d5f5)
sivel pushed a commit that referenced this pull request Sep 28, 2022
@bcoca
documented windows filters (#78876) (#78892)
30b7bfc 
* documented windows filters

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 7c4d5f5)
@ansible ansible locked and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.15 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcoca @felixfontein @samccann @ansibot @s-hertel