Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] ansible-galaxy - fix unnecessary api check when installing role #79143

Merged
merged 3 commits into from Oct 26, 2022

Conversation

s-hertel
Copy link
Contributor

SUMMARY

…from git repo (#79090)

  • delay server api evaluation until a GalaxyRole needs to make an api call for info, list, and install

(cherry picked from commit cb2e434)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

ADDITIONAL INFORMATION

…role from git repo (ansible#79090)

* delay server api evaluation until a GalaxyRole needs to make an api call for info, list, and install

(cherry picked from commit cb2e434)
@ansibot ansibot added affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Oct 14, 2022
@s-hertel s-hertel marked this pull request as draft October 17, 2022 19:56
@s-hertel
Copy link
Contributor Author

Marked as a draft until #79090 (comment) is fixed.

@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Oct 17, 2022
Use GalaxyAPI for isinstance check instead of RoleDistributionServer, since the latter is defined in __main__ sometimes (when running integration tests or ansible-galaxy from source) and importing from ansible.cli.galaxy won't reference the same object.

(cherry picked from commit 89d6824)
@s-hertel s-hertel marked this pull request as ready for review October 18, 2022 12:29
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2022
@sivel sivel merged commit 65fd4e1 into ansible:stable-2.13 Oct 26, 2022
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 27, 2022
@ansible ansible locked and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 backport This PR does not target the devel branch. bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants