Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict wheel below v0.38.0 under Pythons < 3.7 #79187

Merged
merged 4 commits into from Oct 24, 2022

Conversation

webknjaz
Copy link
Member

SUMMARY

This is needed in envs with old pip that doesn't know how to treat Python-Require in dist metadata.

ISSUE TYPE
  • Maintenance Pull Request
  • Test Pull Request
COMPONENT NAME

pip integration test

ADDITIONAL INFORMATION

https://github.com/pypa/wheel/releases/tag/0.38.0

Copy link
Member

@mattclay mattclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It just needs a changelog fragment.

@ansibot ansibot added affects_2.15 needs_triage Needs a first human triage before being processed. test This PR relates to tests. labels Oct 21, 2022
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Oct 21, 2022
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 21, 2022
@webknjaz
Copy link
Member Author

@mattclay this is odd: https://dev.azure.com/ansible/ansible/_build/results?buildId=57804&view=logs&jobId=0fc95b7a-aeb2-51d1-ca66-0c5da281b763&j=832187f9-b1bd-5055-d617-d8275c56320a. Does azure experience problems? 🤔

##[error]System.IO.IOException: No space left on device
   at System.IO.FileStream.WriteNative(ReadOnlySpan`1 source)
   at System.IO.FileStream.FlushWriteBuffer()
   at System.IO.FileStream.Flush(Boolean flushToDisk)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at Microsoft.VisualStudio.Services.Agent.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
   at Microsoft.VisualStudio.Services.Agent.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
   at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
   at Microsoft.VisualStudio.Services.Agent.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
   at Microsoft.VisualStudio.Services.Agent.Worker.Program.MainAsync(IHostContext context, String[] args)
System.IO.IOException: No space left on device
   at System.IO.FileStream.WriteNative(ReadOnlySpan`1 source)
   at System.IO.FileStream.FlushWriteBuffer()
   at System.IO.FileStream.Flush(Boolean flushToDisk)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at Microsoft.VisualStudio.Services.Agent.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
   at Microsoft.VisualStudio.Services.Agent.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
   at Microsoft.VisualStudio.Services.Agent.HostContext.Dispose(Boolean disposing)
   at Microsoft.VisualStudio.Services.Agent.HostContext.Dispose()
   at Microsoft.VisualStudio.Services.Agent.Worker.Program.Main(String[] args)
,##[error]We stopped hearing from agent agent7dbf0065QE. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

@mattclay
Copy link
Member

@mattclay this is odd: https://dev.azure.com/ansible/ansible/_build/results?buildId=57804&view=logs&jobId=0fc95b7a-aeb2-51d1-ca66-0c5da281b763&j=832187f9-b1bd-5055-d617-d8275c56320a. Does azure experience problems? 🤔

##[error]System.IO.IOException: No space left on device

Some of the VMSS instances have run out of disk space due to caching too many container images. The issue should resolve itself when those instances are removed from the agent pool.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 21, 2022
Co-authored-by: Matt Clay <matt@mystile.com>
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 21, 2022
@mattclay
Copy link
Member

It looks like the pip integration test isn't using the constraint, as it's still trying to install an incompatible version.

@webknjaz
Copy link
Member Author

It looks like the pip integration test isn't using the constraint, as it's still trying to install an incompatible version.

Right... I've been meaning to add it there and forgot 🤦‍♂️

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 24, 2022
@webknjaz
Copy link
Member Author

Incidental Windows Server 2012:

07:05 The windows 2012 (x86_64) [target] @aws instance is starting.
07:16 ERROR: Host <ansible_test._internal.host_profiles.WindowsRemoteProfile object at 0x7f6d18990190> job failed: Command "curl -s -S -i -X GET -H 'Expect: ' https://ansible-core-ci.testing.ansible.com/prod/aws/************************************" returned exit status 35.
07:16 >>> Standard Error
07:16 curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to ansible-core-ci.testing.ansible.com:443

This one will need to be restarted.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 24, 2022
@mattclay mattclay merged commit a76bbb1 into ansible:devel Oct 24, 2022
mattclay pushed a commit to mattclay/ansible that referenced this pull request Oct 24, 2022
…ible#79187)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR ansible#79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit to mattclay/ansible that referenced this pull request Oct 24, 2022
…ible#79187)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR ansible#79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit to mattclay/ansible that referenced this pull request Oct 24, 2022
…ible#79187)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR ansible#79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>.
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit to mattclay/ansible that referenced this pull request Oct 24, 2022
…ible#79187)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR ansible#79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>.
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit that referenced this pull request Oct 24, 2022
)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR #79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit that referenced this pull request Oct 24, 2022
)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR #79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit that referenced this pull request Oct 25, 2022
)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR #79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>.
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
mattclay pushed a commit that referenced this pull request Oct 25, 2022
)

* Restrict `wheel` below v0.38.0 under Pythons < 3.7

* Add a change note for PR #79187

* Update changelogs/fragments/79187--wheel-0.38.0.yml

Co-authored-by: Matt Clay <matt@mystile.com>

* Use constraints file when installing wheel.

Co-authored-by: Matt Clay <matt@mystile.com>.
(cherry picked from commit a76bbb1)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@ansible ansible locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.15 test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants