Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable docs build: do not use YAML parsing/serialization for .deps files #79233

Merged
merged 2 commits into from Oct 26, 2022

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Right now the stable docs build fails when a .deps file has _python in it, since its value >=3.9 is not a valid YAML value.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

hacking/build_library/build_ansible/command_plugins/docs_build.py

@felixfontein felixfontein marked this pull request as ready for review October 26, 2022 20:46
@felixfontein
Copy link
Contributor Author

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Oct 26, 2022
@samccann
Copy link
Contributor

PR staged on test site and seems to work

@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Oct 26, 2022
@mattclay mattclay merged commit 9545f2e into ansible:devel Oct 26, 2022
samccann pushed a commit to samccann/ansible that referenced this pull request Oct 26, 2022
…les (ansible#79233)

* Do not use YAML parsing/serialization for .deps files.

* Prevent crash.

(cherry picked from commit 9545f2e)
mattclay pushed a commit that referenced this pull request Oct 26, 2022
…les (#79233) (#79234)

* Do not use YAML parsing/serialization for .deps files.

* Prevent crash.

(cherry picked from commit 9545f2e)

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein deleted the fix-docs-build branch October 27, 2022 04:32
@felixfontein
Copy link
Contributor Author

@samccann @mattclay thanks for testing, reviewing, merging, and backporting :)

felixfontein added a commit to felixfontein/ansible that referenced this pull request Oct 27, 2022
…les (ansible#79233)

* Do not use YAML parsing/serialization for .deps files.

* Prevent crash.

(cherry picked from commit 9545f2e)
sivel pushed a commit that referenced this pull request Oct 27, 2022
…les (#79233) (#79237)

* Do not use YAML parsing/serialization for .deps files.

* Prevent crash.

(cherry picked from commit 9545f2e)
@ansible ansible locked and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.15 bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants