New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stable docs build: do not use YAML parsing/serialization for .deps files #79233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the docs build for Ansible 6 and Ansible 7 fails due to https://github.com/ansible-community/ansible-build-data/blob/main/6/ansible-6.5.0.deps#L3 and https://github.com/ansible-community/ansible-build-data/blob/main/7/ansible-7.0.0a2.deps#L3. |
felixfontein
force-pushed
the
fix-docs-build
branch
from
October 26, 2022 20:51
449a676
to
c5106a2
Compare
ansibot
added
affects_2.15
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
labels
Oct 26, 2022
PR staged on test site and seems to work |
samccann
approved these changes
Oct 26, 2022
mattclay
removed
the
needs_triage
Needs a first human triage before being processed.
label
Oct 26, 2022
samccann
pushed a commit
to samccann/ansible
that referenced
this pull request
Oct 26, 2022
…les (ansible#79233) * Do not use YAML parsing/serialization for .deps files. * Prevent crash. (cherry picked from commit 9545f2e)
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Oct 27, 2022
…les (ansible#79233) * Do not use YAML parsing/serialization for .deps files. * Prevent crash. (cherry picked from commit 9545f2e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Right now the stable docs build fails when a
.deps
file has_python
in it, since its value>=3.9
is not a valid YAML value.ISSUE TYPE
COMPONENT NAME
hacking/build_library/build_ansible/command_plugins/docs_build.py