-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document where to save cloud config files #79412
document where to save cloud config files #79412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the cloud-
prefixed templates are handled the same way, so the boilerplate should be updated on all of them.
What should the boilerplate say for the openshift one? It currently says:
The point of this change is that you're not supposed to modify these files or put files into the same folders. I don't understand the point of that file. There's nothing in it. Is it just supposed to be some instructions, which are located in the same place as instructions for other modules? Should it say:
|
f12e216
to
e6d082f
Compare
Yes, that should work. The instructions in all of these template files were created when they originally resided in the |
Ok, now I've updated all the cloud- files. |
e6d082f
to
23b536f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one minor cosmetic change requested.
test/lib/ansible_test/config/cloud-config-cloudscale.ini.template
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Clay <matt@mystile.com>
@mdavis-xyz Thanks for fixing this. |
SUMMARY
This fixes part of #79411.
This fixes the comment part.
And the part about the optional
security_token
field.This does not modify the error message returned by
ansible-test
.This should help with: ansible-collections/amazon.aws#924
ISSUE TYPE
COMPONENT NAME
config
ADDITIONAL INFORMATION
I don't know what most of those files I modified are. I've only tested AWS stuff previously. So I need someone to confirm that the changes to those other files are applicable to those.
I did not modify the cloudscale one, because that's very barebones. I don't know if it's the same situation as the others.
I did not modify the openshift one, because it already had some mention of putting another file next to this one. That sounds possibly not right. Should both files go into
tests/integration
instead?