Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm_key integration test should also test for deleting by key ID #79584

Closed
kkeane opened this issue Dec 12, 2022 · 1 comment · Fixed by #79729
Closed

rpm_key integration test should also test for deleting by key ID #79584

kkeane opened this issue Dec 12, 2022 · 1 comment · Fixed by #79729
Labels
affects_2.15 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. has_pr This issue has an associated PR.

Comments

@kkeane
Copy link

kkeane commented Dec 12, 2022

Summary

The rpm_key.yaml integration test tests various methods for installing and removing rpm keys, but does not test removing the key by key ID. The key ID for EPEL7 is gpg-pubkey-352c64e5-52ae6884

Issue Type

Feature Idea

Component Name

https://github.com/ansible/ansible/blob/devel/test/integration/targets/rpm_key/tasks/rpm_key.yaml

Additional Information

  • name: remove EPEL GPG key from keyring to confirm that already-deleted keys do not fail
    rpm_key:
    state: absent
    key: gpg-pubkey-352c64e5-52ae6884

  • name: remove EPEL GPG key from keyring (idempotent)
    rpm_key:
    state: absent
    key: gpg-pubkey-352c64e5-52ae6884
    register: idempotent_test

  • name: check idempontence
    assert:
    that: "not idempotent_test.changed"



### Code of Conduct

- [X] I agree to follow the Ansible Code of Conduct
@ansibot
Copy link
Contributor

ansibot commented Dec 12, 2022

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.15 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. labels Dec 12, 2022
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Dec 13, 2022
@gryu7 gryu7 mentioned this issue Jan 13, 2023
Merged
@ansibot ansibot added the has_pr This issue has an associated PR. label Jan 13, 2023
@ansible ansible locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.15 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. has_pr This issue has an associated PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add task for testing to remove gpg key using key id gryu7/ansible
3 participants
@kkeane @mkrizek @ansibot