-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: documentation for per-task timeout #79715
Conversation
##### SUMMARY <!--- Your description here --> Corrected the documentation regarding per-task timeouts. The timeout variable is not available in all modules in the way it is shown. See for example ``` - hosts: all tasks: - name: show version cisco.nxos.nxos_command: commands: "show version" retries: 1 timeout: 60 ``` which leads to ``` fatal: [rcn-lab-s-2.lab.tmn.scc.kit.edu]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (cisco.nxos.nxos_command) module: timeout. Supported parameters include: interval, wait_for (waitfor), retries, commands, match."} ``` ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr
Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda. |
You are confusing the per task The documentation you are updating ONLY refers to the second one. |
By task level option you refer to this list: https://docs.ansible.com/ansible/latest/reference_appendices/playbooks_keywords.html#task But then there is an error in the indentation. Currently it is:
But it should be:
|
yes, that is the task level one, some modules implement their own so it can be confusing and the indentation makes the difference. Also |
Okay, so to summarize, there are 3 ways to do it:
I think that the documentation does not make these 3 ways and the varying support by different modules very clear. |
docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
Outdated
Show resolved
Hide resolved
|
docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
Outdated
Show resolved
Hide resolved
Thanks @991jo |
(cherry picked from commit 48e6bf8)
* fix filename for sidecar docs (#79779) (cherry picked from commit f2707d1) * correct examples to use removed_from_collection not collection_name (#79803) (cherry picked from commit 7ab3de7) * Fix: documentation for per-task timeout (#79715) (cherry picked from commit 48e6bf8) * [Docs] maintainers_guidelines: add WG and real-time chat request info (#79750) (cherry picked from commit 6cb6d65) * doc fix for platform content #79794 (#79801) (cherry picked from commit d7a4152) * Expand docs for the import sanity test. (#79768) * Expand docs for the import sanity test. * Remove note about Python 2.7 compat. It should not be needed since there is a sanity test to enforce use of `__metaclass__ = type`. * Improve introductory paragraph. * Fix link typo. (cherry picked from commit 2164d56) * docs: Extend password entry of ansible.builtin.user (#79694) * docs: Extend password entry of ansible.builtin.user Clarify that `password` sets the password hash. Not the actual password. Fixes part of #79684 (cherry picked from commit 6cd1a14) * Update dev_guide.rst (#79625) (cherry picked from commit 65eb5c0) * Improve documentation on requirements.yml (#76140) Makes it clear that user can use range identifiers with collection versions inside requirements.yml files. (cherry picked from commit 44dcfde) --------- Co-authored-by: Evgeni Golov <evgeni@golov.de> Co-authored-by: Jo <jo@swagspace.org> Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> Co-authored-by: prasadpatil49 <51715670+prasadpatil49@users.noreply.github.com> Co-authored-by: Matt Clay <matt@mystile.com> Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> Co-authored-by: Jens Timmerman <github@caret.be> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
SUMMARY
Corrected the documentation regarding per-task timeouts. The timeout variable is not available in all modules in the way it is shown. See for example
which leads to
ISSUE TYPE
+label: docsite_pr