Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show filename additionally if missing secrets prevents decryption #79732

Merged
merged 1 commit into from Jan 18, 2023
Merged

Show filename additionally if missing secrets prevents decryption #79732

merged 1 commit into from Jan 18, 2023

Conversation

CarstenGrohmann
Copy link
Contributor

SUMMARY

Display the file name in addition to the error message A vault password must be specified to decrypt the data if decryption secrets are missing. If the file name is not provided, it is difficult to understand which of the vault files is causing the problem.

Fixes #79723

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vault

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch labels Jan 13, 2023
@CarstenGrohmann CarstenGrohmann mentioned this pull request Jan 13, 2023
Closed
1 task
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 17, 2023
mkrizek
mkrizek requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@mkrizek mkrizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a changelog fragment.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 17, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch labels Jan 17, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 18, 2023
@mkrizek mkrizek merged commit 6c0559b into ansible:devel Jan 18, 2023
@CarstenGrohmann CarstenGrohmann deleted the issue-79723 branch January 18, 2023 09:20
@ansible ansible locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.15 bug This issue/PR relates to a bug. has_issue new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filename to error message "A vault password must be specified to decrypt data"
3 participants
@CarstenGrohmann @mkrizek @ansibot