Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback in template action with ANSIBLE_DEBUG=1 #79764

Merged
merged 3 commits into from Jan 20, 2023

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jan 19, 2023

SUMMARY

Introduced in 884244f

Fixes #79763

Just revert the change from the commit above based on the following dummy perf test:

% python -m timeit -s 'd = {"a": 1}; o = {"a": 2}' 'n = d.copy(); n.update(o)'
2000000 loops, best of 5: 128 nsec per loop

% python -m timeit -s 'd = {"a": 1}; o = {"a": 2}' 'n = d | o'                
5000000 loops, best of 5: 76.6 nsec per loop

% python -m timeit -s 'd = {"a": 1}; o = {"a": 2}' 'n = dict(d) | o'
2000000 loops, best of 5: 155 nsec per loop
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/template.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 19, 2023
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jan 19, 2023
@mkrizek mkrizek merged commit 4f5ed24 into ansible:devel Jan 20, 2023
@mkrizek mkrizek deleted the issue-79763 branch January 20, 2023 08:39
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jan 20, 2023
sivel pushed a commit that referenced this pull request Jan 23, 2023
@ansible ansible locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.15 bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANSIBLE_DEBUG causes template to fail
4 participants