fix installing collections from git repos that contain MANIFEST.json #79808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng MANIFEST.json changelog
ansibot
added
affects_2.15
bug
sivel
reviewed
Jan 24, 2023
sivel
approved these changes
Jan 24, 2023
s-hertel
force-pushed
the
a-g-fix-installing-built-git-src
branch
from
d2eabf0
to
ded17a0
Compare
ansibot
added
the
needs_revision
ansibot
added
shipit
|
I thought we had established that to install from git |
ansibot
added
shipit
|
@bcoca That was the plan, but it changed in 2.11 with the feature of installing collections from non-git dir/subdirs. Now SCM collections are just a wrapper collection that has a dir or subdirs dependency. We would have needed to make a distinction between directories that originate from SCM collections and other directories, and that was vetoed at the time. |
ansibot
added
shipit
s-hertel
added
the
ci_verified
ansibot
removed
ci_verified
ansibot
added
the
needs_revision
s-hertel
force-pushed
the
a-g-fix-installing-built-git-src
branch
from
da0b114
to
283511f
Compare
ansibot
removed
the
needs_revision
s-hertel
commented
Jan 26, 2023
changelogs/fragments/ansible-galaxy-install-git-src-manifest.yml
Outdated
Show resolved
Hide resolved
mattclay
removed
the
needs_triage
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Jan 26, 2023
…nsible#79808) * add null 'manifest' key to metadata for git repo collections containing MANIFEST.json changelog * set to Sentinel instead of None * Test installing a collection in a git repo that contains a MANIFEST.json * fix test * Update changelogs/fragments/ansible-galaxy-install-git-src-manifest.yml (cherry picked from commit 321848e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #79796
As of 595413d, collections in git repos can contain a galaxy.yml or MANIFEST.json (just like non-git repo directories).
ISSUE TYPE
COMPONENT NAME
ansible-galaxy collection install