Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible.Basic.cs - Fix compile error on PS 7.3.x #79848

Merged
merged 1 commit into from Jan 30, 2023
Merged

Ansible.Basic.cs - Fix compile error on PS 7.3.x #79848

merged 1 commit into from Jan 30, 2023

Conversation

mattclay
Copy link
Member

SUMMARY

Ansible.Basic.cs - Fix compile error on PS 7.3.x

This issue was discovered while trying to upgrade the base test container: #79846

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

lib/ansible/module_utils/csharp/Ansible.Basic.cs

ADDITIONAL INFORMATION

The reported error is:

Line |
 247 |  …             throw [InvalidOperationException]"Failed to compile C# co …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Failed to compile C# code:
error CS1701: Assuming assembly reference 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' used by 'Newtonsoft.Json' matches identity 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' of 'System.Runtime', you may need to supply runtime policy

Which comes from:

ansible/lib/ansible/module_utils/powershell/Ansible.ModuleUtils.AddType.psm1

Line 247 in 10f0e5f

throw [InvalidOperationException]"Failed to compile C# code:`r`n$($errors -join "`r`n")"

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. windows Windows community labels Jan 30, 2023
@jborean93 jborean93 merged commit 83fe75d into ansible:devel Jan 30, 2023
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jan 30, 2023
@mattclay mattclay deleted the fix-powershell branch January 30, 2023 20:21
mattclay added a commit to mattclay/ansible that referenced this pull request Jan 30, 2023
@mattclay
[stable-2.14] Ansible.Basic.cs - Fix compile error on PS 7.3.x (ansib…
c4575f9 
…le#79848)

(cherry picked from commit 83fe75d)

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to mattclay/ansible that referenced this pull request Jan 30, 2023
@mattclay
[stable-2.13] Ansible.Basic.cs - Fix compile error on PS 7.3.x (ansib…
95d4046 
…le#79848)

(cherry picked from commit 83fe75d)

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to mattclay/ansible that referenced this pull request Jan 30, 2023
@mattclay
[stable-2.12] Ansible.Basic.cs - Fix compile error on PS 7.3.x (ansib…
10c0fc7 
…le#79848)

(cherry picked from commit 83fe75d)

Co-authored-by: Matt Clay <matt@mystile.com>
This was referenced Jan 30, 2023
Merged
Merged
Merged
mattclay added a commit that referenced this pull request Feb 3, 2023
@mattclay
[stable-2.14] Ansible.Basic.cs - Fix compile error on PS 7.3.x (#79848)…
05ec8b6 
… (#79850)

(cherry picked from commit 83fe75d)
mattclay added a commit that referenced this pull request Feb 3, 2023
@mattclay
[stable-2.13] Ansible.Basic.cs - Fix compile error on PS 7.3.x (#79848)…
6342913 
… (#79851)

(cherry picked from commit 83fe75d)
mattclay added a commit that referenced this pull request Feb 3, 2023
@mattclay
[stable-2.12] Ansible.Basic.cs - Fix compile error on PS 7.3.x (#79848)…
c698494 
… (#79852)

(cherry picked from commit 83fe75d)
@ansible ansible locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.15 bug This issue/PR relates to a bug. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattclay @jborean93 @ansibot