Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user - fix comparing existing group names to group IDs #79981

Merged
merged 2 commits into from Feb 14, 2023

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Fixes #79956

User().user_group_membership() returns group names which are compared with the result from User().get_groups_set() which can return names or IDs. I added a new parameter to just return group names.

DarwinUser didn't allow group IDs for group modification, so also fixed that by using get_groups_set there as well.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

user module

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Feb 10, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 14, 2023
@mkrizek mkrizek merged commit 556dadb into ansible:devel Feb 14, 2023
@ansible ansible locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.15 bug This issue/PR relates to a bug. module This issue/PR relates to a module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User module reports 'changed: true' when group is numeric, even if user is already a member of group
3 participants