Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-test - Remove auto format pylint rule #79985

Merged
merged 1 commit into from Feb 13, 2023

Conversation

mattclay
Copy link
Member

SUMMARY

Removed the ansible-format-automatic-specification rule from the pylint sanity test, now that Python 2.6 is no longer supported.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible-test

@ansibot ansibot added affects_2.15 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. test This PR relates to tests. labels Feb 11, 2023
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Feb 11, 2023
@mattclay mattclay merged commit 10bc8af into ansible:devel Feb 13, 2023
@mattclay mattclay deleted the at-pylint-string-format branch February 13, 2023 17:21
@evgeni
Copy link
Contributor

evgeni commented Feb 14, 2023

@mattclay are you planing to backport this to other releases that don't support 2.6 (2.14+)?

I am asking because now my devel tests are failing with:

unknown-option-value: Unknown option value for 'disable', expected a valid pylint message and got 'ansible-format-automatic-specification'

But on stable branches, ansible-test will complain about our code using {} formats as our collection didn't ever support 2.6, if we remove the disable block.

@mattclay
Copy link
Member Author

@evgeni No, this won't be backported. However, to ease the transition I've opened #79997 to disable the rule instead of removing it entirely. I wasn't expecting anyone to have used inline ignores for this. Sorry for the inconvenience.

@ansible ansible locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.15 bug This issue/PR relates to a bug. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants