Fact "ansible_virtualization_type" incorrect on Microsoft laptops

[sbivol]

Summary

Ansible uses /sys/devices/virtual/dmi/id/sys_vendor to determine if the system is virtualized, but the test incorrectly assumes that "Microsoft Corporation" always means VirtualPC.

The facts ansible_virtualization_tech_guest and ansible_virtualization_type are also incorrect on this laptop.

Issue Type

Bug Report

Component Name

lib/ansible/module_utils/facts/virtual/linux.py

Ansible Version

$ ansible --version
ansible [core 2.14.3]

Configuration

N/A

OS / Environment

Ubuntu 22.04

$ cat /sys/devices/virtual/dmi/id/sys_vendor
Microsoft Corporation

$ cat /sys/devices/virtual/dmi/id/product_family
Surface

$ sudo dmidecode | grep -B1 "Microsoft\|Surface"
BIOS Information
        Vendor: Microsoft Corporation
--
System Information
        Manufacturer: Microsoft Corporation
        Product Name: Surface Laptop Go
--
        Wake-up Type: Unknown
        SKU Number: Surface_Laptop_Go_1943
        Family: Surface
--
Chassis Information
        Manufacturer: Microsoft Corporation
--
Base Board Information
        Manufacturer: Microsoft Corporation
        Product Name: Surface Laptop Go

Steps to Reproduce

$ ansible -i localhost, all -m setup | grep -A1 ansible_virtualization

Expected Results

Ansible should report a physical machine, not virtual.

Actual Results

"ansible_virtualization_role": "guest",
"ansible_virtualization_tech_guest": [
    "VirtualPC"
],
"ansible_virtualization_tech_host": [
    "kvm"
],
"ansible_virtualization_type": "VirtualPC",

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• lib/ansible/module_utils/facts/virtual/linux.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help