Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for argument_specs to hide variables in argument_spec_data that did not fail #80531

Open
1 task done
ryanmerolle opened this issue Apr 16, 2023 · 3 comments
Open
1 task done
Labels
affects_2.16 feature This issue/PR relates to a feature request. module This issue/PR relates to a module.

Comments

@ryanmerolle
Copy link
Contributor

Summary

Adding a meta/argument_specs.yml to a role is quite helpful for input validation, but it can get quite noisy for roles with quite a few variables in the argument_specs definition. It would be nice to add to some sort of configuration variable (several possible options one where this could be set), allow you to display either:

  • full (current behavior of showing full argument_spec_data)
  • failed (only show the data for variables with errors)
  • none (do not show any argument_spec_data since the argument_errors and msg keys give relevant error details)

Issue Type

Feature Idea

Component Name

role validate_argument_spec

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibot
Copy link
Contributor

ansibot commented Apr 16, 2023

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.16 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Apr 16, 2023
@ryanmerolle ryanmerolle changed the title Add option for argument_specs to high variables in argument_spec_data that did not fail Add option for argument_specs to hide variables in argument_spec_data that did not fail Apr 16, 2023
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 18, 2023
@bcoca
Copy link
Member

bcoca commented Apr 18, 2023

waiting_on_contributor

@ansibot ansibot added the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Apr 18, 2023
@s-hertel s-hertel removed the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Apr 10, 2024
@nitzmahone
Copy link
Member

We've added this to our 2.18 planning backlog as a discussion item. It's a reasonable ask on its own, but there are similar issues where hardcoded task result elision happens in the callback dump/display- it'd be good to come up with a more standard task-provided "hint" to the callback to elide these kinds of tasks, along with a single knob to easily disable it everywhere for forensic purposes without hacking the playbook/task itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.16 feature This issue/PR relates to a feature request. module This issue/PR relates to a module.
Projects
ansible-core 2.18
  
Awaiting triage
Development

No branches or pull requests

5 participants