Remove __future__ and metaclass boilerplate from controller code

[nitzmahone]

Summary

Since we've dropped 2.x support for the controller, we can remove the old 2.x future and metaclass boilerplate from non-target-side code.

Issue Type

Feature Idea

Component Name

controller code, sanity tests

Additional Information

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• test/integration/targets/ansible-test-sanity/ansible_collections/ns/col/tests/sanity/ignore.txt

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[mattclay]

The future-import-boilerplate and metaclass-boilerplate sanity tests were already updated in 2.12 to only apply to code that runs on Python 2.7.

[mattclay]

I've updated the title and description to reflect that the sanity tests don't require updates, only the code. I also included the metaclass boilerplate in this issue, since there's no point in removing them separately.

[mattclay]

There are other changes to consider, although they should be separate issue(s) if we're going to implement them:

1. Do we want to make the from __future__ import annotations our new standard controller boilerplate for ansible-core? It can be (and is) used currently, but it's not enforced by sanity tests (except for ansible-test code that runs on the controller).
2. Do we want to prohibit the use of the now outdated Python 2.7 compatibility boilerplate for ansible-core controller code? That would keep it from finding its way back into the code after we remove it.