Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate templar.environment, only overlay on local myenv #81005

Merged
merged 10 commits into from Jun 13, 2023
Merged

Don't mutate templar.environment, only overlay on local myenv #81005

merged 10 commits into from Jun 13, 2023

Conversation

sivel
Copy link
Member

@sivel sivel commented Jun 8, 2023

SUMMARY

Don't mutate templar.environment, only overlay on local myenv

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/template.py

ADDITIONAL INFORMATION

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.16 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jun 8, 2023
@sivel sivel force-pushed the template-action-no-mutate branch from 00d74ec to b4baa20 Compare June 8, 2023 23:01
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jun 8, 2023
@ansibot
Copy link
Contributor

ansibot commented Jun 8, 2023

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/action/template.py:143:23: E126: continuation line over-indented for hanging indent

click here for bot help

@sivel sivel marked this pull request as ready for review June 12, 2023 18:26
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 12, 2023
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 13, 2023
@sivel sivel merged commit 73e04ef into ansible:devel Jun 13, 2023
85 checks passed
This was referenced Jun 13, 2023
Closed
Closed
sivel added a commit to sivel/ansible that referenced this pull request Jun 13, 2023
@sivel
[stable-2.15] Don't mutate templar.environment, only overlay on local…
ac62d01 
… myenv (ansible#81005).

(cherry picked from commit 73e04ef)

Co-authored-by: Matt Martz <matt@sivel.net>
@ansible ansible locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.16 bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @ansibot @bcoca @mkrizek