Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.15] Consider all configured collection paths when installing collections #81324

Merged
merged 2 commits into from Aug 3, 2023

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Backport for #81243

  • Only install collections which can't be satisfied by a collection in any of the configured paths.

  • Improve warning for unexpected collection install path

Fix warning when path is configured, but is a pip-managed path

Normalize the path before validating to fix warning consistency

(cherry picked from commit efbc00b)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

…nsible#81243)

* Only install collections which can't be satisfied by a collection in any of the configured paths.

* Improve warning for unexpected collection install path

Fix warning when path is configured, but is a pip-managed path

Normalize the path before validating to fix warning consistency

(cherry picked from commit efbc00b)
@s-hertel s-hertel changed the title Consider all configured collection paths when installing collections [2.15] Consider all configured collection paths when installing collections Jul 20, 2023
@ansibot ansibot added needs_triage Needs a first human triage before being processed. backport This PR does not target the devel branch. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 20, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 21, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 1, 2023
@sivel
Copy link
Member

sivel commented Aug 2, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added bug This issue/PR relates to a bug. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 2, 2023
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Aug 3, 2023
@sivel sivel merged commit 85a3eb2 into ansible:stable-2.15 Aug 3, 2023
83 checks passed
@ansible ansible locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants