win_fetch - improve test time by not scanning Win dir #81884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
force-pushed
the
win-fetch-size
branch
from
1b2678c
to
e5778a3
Compare
ansibot
added
test
mattclay
approved these changes
Oct 4, 2023
mattclay
removed
the
needs_triage
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit dfc6258)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit dfc6258)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit dfc6258)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit dfc6258)
This was referenced Oct 4, 2023
mattclay
pushed a commit
that referenced
this pull request
Oct 4, 2023
mattclay
pushed a commit
that referenced
this pull request
Oct 4, 2023
mattclay
pushed a commit
that referenced
this pull request
Oct 4, 2023
mattclay
pushed a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A part of the fetch operation is to call
staton the path specified. For Windows this means it'll get the size of the target which can be an expensive operation for directories with lots of children. This changes the test so it uses an empty dir to speed up the test times.ISSUE TYPE