Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jinja plugin deduplication #82002

Merged
merged 9 commits into from Oct 20, 2023
Merged

Fix Jinja plugin deduplication #82002

merged 9 commits into from Oct 20, 2023

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 17, 2023

fixes #81897

ISSUE TYPE
  • Bugfix Pull Request

@bcoca bcoca requested a review from nitzmahone October 17, 2023 16:43
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 17, 2023
@yogo1212
Copy link

yogo1212 commented Oct 18, 2023

I thought that I'd encountered yet another pitfall with using filter plugins and was just about to pull my hair out and become a monk.
This PR caught my attention just in the nick of time!

Thanks, my friend, for allowing me to continue living in a heated house with plumbing and such.

 also added docs to make test happy
@ansible ansible deleted a comment from ansibot Oct 18, 2023
@ansibot

This comment was marked as resolved.

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Oct 18, 2023
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Oct 18, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 19, 2023
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Oct 19, 2023
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that oughtta do it- thanks!

@bcoca bcoca merged commit b4566c1 into ansible:devel Oct 20, 2023
62 checks passed
@bcoca bcoca deleted the dedupe_j2 branch October 20, 2023 23:00
bcoca added a commit to bcoca/ansible that referenced this pull request Oct 20, 2023
for j2 plugins dedupe on path and  not basename
for j2 this is a container file , for other plugins file name == plugin name

(cherry picked from commit b4566c1)
bcoca added a commit to bcoca/ansible that referenced this pull request Oct 20, 2023
for j2 plugins dedupe on path and  not basename
for j2 this is a container file , for other plugins file name == plugin name

(cherry picked from commit b4566c1)
sivel pushed a commit that referenced this pull request Oct 26, 2023
for j2 plugins dedupe on path and  not basename
for j2 this is a container file , for other plugins file name == plugin name

(cherry picked from commit b4566c1)
@ansible ansible locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. has_issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Jinja plugin caching breaks loading multiple custom filter plugins with same name
7 participants