Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait_for, fallback to read for non mmapable files #82064

Merged
merged 10 commits into from Nov 16, 2023
Merged

wait_for, fallback to read for non mmapable files #82064

merged 10 commits into from Nov 16, 2023

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 23, 2023

fixes #79683

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 23, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 24, 2023
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Oct 30, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 6, 2023
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 15, 2023
@ansible ansible deleted a comment from ansibot Nov 15, 2023
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 15, 2023
@sivel sivel self-requested a review November 16, 2023 19:55
@bcoca bcoca merged commit 8b102dc into ansible:devel Nov 16, 2023
62 checks passed
@bcoca bcoca deleted the fix_wait_for branch November 16, 2023 23:02
bcoca added a commit to bcoca/ansible that referenced this pull request Nov 16, 2023
@bcoca
wait_for, fallback to read for non mmapable files (ansible#82064)
a92285d 
* also handle oserror, added debug jic

(cherry picked from commit 8b102dc)
bcoca added a commit to bcoca/ansible that referenced this pull request Nov 16, 2023
@bcoca
wait_for, fallback to read for non mmapable files (ansible#82064)
29a661d 
* also handle oserror, added debug jic

(cherry picked from commit 8b102dc)
sivel pushed a commit that referenced this pull request Nov 27, 2023
@bcoca
wait_for, fallback to read for non mmapable files (#82064) (#82234)
23cd32e 
* wait_for, fallback to read for non mmapable files (#82064)

(cherry picked from commit 8b102dc)
nitzmahone pushed a commit that referenced this pull request Nov 27, 2023
@bcoca
wait_for, fallback to read for non mmapable files (#82064) (#82233)
fb5d254 
* wait_for, fallback to read for non mmapable files (#82064)

* also handle oserror, added debug jic

(cherry picked from commit 8b102dc)

* skip problem versions
@ansible ansible locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. has_issue module This issue/PR relates to a module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wait_for no longer works for files in e.g. sysfs because it uses mmap() instead of read()
5 participants
@bcoca @sivel @webknjaz @mkrizek @ansibot