restore role param precedence #82106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
bcoca
force-pushed
the
restore_role_param_precedence
branch
from
d47de20
to
51761b4
Compare
|
Looks good to me. Should we change 0b678d5#diff-8e95e931e9ed766f3de92129229d00f622fbc1bf887e2843bc730e0f51dd11a8R495 back to pass include_params to deps? (PR that made this change also hardcoded it to False there) |
mattclay
removed
the
needs_triage
|
should not as they are explicitly called a few lines later, when not doing only exports |
ansibot
added
needs_revision
|
Ah, right. |
s-hertel
approved these changes
Nov 6, 2023
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Nov 6, 2023
* add test for setfact/param override (cherry picked from commit 20a54eb)
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Nov 6, 2023
* add test for setfact/param override (cherry picked from commit 20a54eb)
sivel
pushed a commit
that referenced
this pull request
Nov 27, 2023
nitzmahone
pushed a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #81474
ISSUE TYPE