Incorrect behaviour after flush_handlers

[m-krs]

Summary

ansible-core 2.14 has introduced a bug with handlers that impacts the next executed task.

Issue Type

Bug Report

Component Name

meta

Ansible Version

ansible [core 2.16.1]
  config file = None
  configured module search path = ['/Users/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/user/.pyenv/versions/3.10.2/envs/ansible-9.1.0/lib/python3.10/site-packages/ansible
  ansible collection location = /Users/user/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/user/.pyenv/versions/ansible-9.1.0/bin/ansible
  python version = 3.10.2 (main, Jun  6 2022, 10:23:56) [Clang 13.1.6 (clang-1316.0.21.2.5)] (/Users/user/.pyenv/versions/3.10.2/envs/ansible-9.1.0/bin/python3.10)
  jinja version = 3.1.2
  libyaml = True

Configuration

CONFIG_FILE() = None

OS / Environment

Darwin Kernel Version 22.6.0

Steps to Reproduce

ansible-playbook -i host1,host2,host3 main.yml

- name: Test
  hosts: all
  connection: local
  gather_facts: false
  handlers:
    - name: run_handler
      ansible.builtin.debug:
        msg: run_handler
  tasks:
    - name: Trigger handler
      ansible.builtin.debug:
        msg: test
      changed_when: true
      when: inventory_hostname == 'host1'
      notify:
        - run_handler

    - name: Flush_handlers
      ansible.builtin.meta: flush_handlers

    - name: Wrong order
      ansible.builtin.debug:
        msg: What's wrong with the order? And look at the task name.

    - name: Next task is ok
      ansible.builtin.debug:
        msg: Next task is ok.

Expected Results

❯   ansible-playbook -i host1,host2,host3 main.yml -vvvv
ansible-playbook [core 2.13.13]
  config file = None
  configured module search path = ['/Users/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/user/.pyenv/versions/3.10.2/envs/ansible-6.7.0/lib/python3.10/site-packages/ansible
  ansible collection location = /Users/user/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/user/.pyenv/versions/ansible-6.7.0/bin/ansible-playbook
  python version = 3.10.2 (main, Jun  6 2022, 10:23:56) [Clang 13.1.6 (clang-1316.0.21.2.5)]
  jinja version = 3.1.2
  libyaml = True
No config file found; using defaults
setting up inventory plugins
Parsed host1,host2,host3 inventory source with host_list plugin
Loading callback plugin default of type stdout, v2.0 from /Users/user/.pyenv/versions/3.10.2/envs/ansible-6.7.0/lib/python3.10/site-packages/ansible/plugins/callback/default.py
Skipping callback 'default', as we already have a stdout callback.
Skipping callback 'minimal', as we already have a stdout callback.
Skipping callback 'oneline', as we already have a stdout callback.

PLAYBOOK: main.yml *****************************************************************************
Positional arguments: main.yml
verbosity: 4
connection: smart
timeout: 10
become_method: sudo
tags: ('all',)
inventory: ('host1,host2,host3',)
forks: 5
1 plays in main.yml

PLAY [Test] ***************************************************************************************
META: ran handlers

TASK [Trigger handler] *****************************************************************************
task path: /Users/user/test/ahandlers/main.yml:10
NOTIFIED HANDLER run_handler for host1
changed: [host1] => {
    "msg": "test"
}
skipping: [host2] => {}
skipping: [host3] => {}

TASK [Flush_handlers] ******************************************************************************
task path: /Users/user/test/ahandlers/main.yml:18

RUNNING HANDLER [run_handler] ******************************************************************
task path: /Users/user/test/ahandlers/main.yml:6
ok: [host1] => {
    "msg": "run_handler"
}
META: ran handlers

TASK [Wrong order] *********************************************************************************
task path: /Users/user/test/ahandlers/main.yml:21
ok: [host1] => {
    "msg": "What's wrong with the order? And look at the task name."
}
ok: [host2] => {
    "msg": "What's wrong with the order? And look at the task name."
}
ok: [host3] => {
    "msg": "What's wrong with the order? And look at the task name."
}

TASK [Next task is ok] ********************************************************************************
task path: /Users/user/test/ahandlers/main.yml:25
ok: [host1] => {
    "msg": "Next task is ok."
}
ok: [host2] => {
    "msg": "Next task is ok."
}
ok: [host3] => {
    "msg": "Next task is ok."
}
META: ran handlers
META: ran handlers

PLAY RECAP *******************************************************************************************
host1                      : ok=4    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   
host2                      : ok=2    changed=0    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0   
host3                      : ok=2    changed=0    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0  

Actual Results

ansible-playbook [core 2.16.1]
  config file = None
  configured module search path = ['/Users/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/user/.pyenv/versions/3.10.2/envs/ansible-9.1.0/lib/python3.10/site-packages/ansible
  ansible collection location = /Users/user/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/user/.pyenv/versions/ansible-9.1.0/bin/ansible-playbook
  python version = 3.10.2 (main, Jun  6 2022, 10:23:56) [Clang 13.1.6 (clang-1316.0.21.2.5)] (/Users/user/.pyenv/versions/3.10.2/envs/ansible-9.1.0/bin/python3.10)
  jinja version = 3.1.2
  libyaml = True
No config file found; using defaults
setting up inventory plugins
Loading collection ansible.builtin from 
Parsed host1,host2,host3 inventory source with host_list plugin
Loading callback plugin default of type stdout, v2.0 from /Users/user/.pyenv/versions/3.10.2/envs/ansible-9.1.0/lib/python3.10/site-packages/ansible/plugins/callback/default.py
Skipping callback 'default', as we already have a stdout callback.
Skipping callback 'minimal', as we already have a stdout callback.
Skipping callback 'oneline', as we already have a stdout callback.

PLAYBOOK: main.yml ************************************************************************************************
Positional arguments: main.yml
verbosity: 4
connection: ssh
become_method: sudo
tags: ('all',)
inventory: ('host1,host2,host3',)
forks: 5
1 plays in main.yml

PLAY [Test] *********************************************************************************************************

TASK [Trigger handler] ***********************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:10
Notification for handler run_handler has been saved.
changed: [host1] => {
    "msg": "test"
}
skipping: [host2] => {
    "false_condition": "inventory_hostname == 'host1'"
}
skipping: [host3] => {
    "false_condition": "inventory_hostname == 'host1'"
}

TASK [Flush_handlers] ***********************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:18
NOTIFIED HANDLER run_handler for host1
META: triggered running handlers for host1

TASK [Flush_handlers] ***********************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:18
META: triggered running handlers for host2

TASK [Flush_handlers] ***********************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:18
META: triggered running handlers for host3

RUNNING HANDLER [run_handler] ***********************************************************************************
task path: /Users/user/test/ahandlers/main.yml:6
ok: [host1] => {
    "msg": "run_handler"
}

TASK [run_handler] **************************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:21
ok: [host2] => {
    "msg": "What's wrong with the order? And look at the task name."
}
ok: [host3] => {
    "msg": "What's wrong with the order? And look at the task name."
}

TASK [Wrong order] *************************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:21
ok: [host1] => {
    "msg": "What's wrong with the order? And look at the task name."
}

TASK [Next task is ok] ***********************************************************************************************
task path: /Users/user/test/ahandlers/main.yml:25
ok: [host1] => {
    "msg": "Next task is ok."
}
ok: [host2] => {
    "msg": "Next task is ok."
}
ok: [host3] => {
    "msg": "Next task is ok."
}

PLAY RECAP *********************************************************************************************************
host1                      : ok=4    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   
host2                      : ok=2    changed=0    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0   
host3                      : ok=2    changed=0    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0 

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibot]

Files identified in the description:

• lib/ansible/modules/meta.py

If these files are incorrect, please update the component name section of the description or use the component bot command.

[ansibot]

@m-krs ansible-core 2.14 is not supported and no longer receives bug fixes. Please test against one of the supported versions of ansible-core, preferably the most recent one, to see whether the bug has been fixed.

click here for bot help

[m-krs]

Updated test with core 2.16.1

[mkrizek]

Duplicate of #82307