Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VMware virt detection for hardware version of ESXi 8.0. #82455

Merged
merged 2 commits into from Jan 9, 2024

Conversation

inntran
Copy link
Contributor

@inntran inntran commented Dec 23, 2023

SUMMARY

Ansible facts is not detecting "virtualization_type" on latest VMware ESXi 8.0.
Current code detects only legacy DMI product_name: 'VMware Virtual Platform', 'VMware7,1'.

On VMware ESXi 8.0, the guest OS is EL9/CentOS Stream 9.

$ cat /sys/devices/virtual/dmi/id/product_name
VMware20,1

I do not have access to ESXi 7 at this moment to enumerate all possible product names on ESXi.

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

I tested locally by modifying "module_utils/facts/virtual/linux.py",
I run command ansible <hostname> -m ansible.builtin.setup and compare the output

Before the patch

        "ansible_virtualization_role": "NA",
        "ansible_virtualization_tech_guest": [],
        "ansible_virtualization_tech_host": [],
        "ansible_virtualization_type": "NA",

After the patch

        "ansible_virtualization_role": "guest",
        "ansible_virtualization_tech_guest": [
            "VMware"
        ],
        "ansible_virtualization_tech_host": [],
        "ansible_virtualization_type": "VMware",

@inntran
Copy link
Contributor Author

inntran commented Dec 24, 2023

Looks like most tests are succeeded, and they are not relevant to my change.

@Akasurde
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2024
@bcoca
Copy link
Member

bcoca commented Jan 2, 2024

still, this requires a changelog

@inntran
Copy link
Contributor Author

inntran commented Jan 2, 2024

still, this requires a changelog

Do I need to add anything to this PR?(regarding the changelog you mentioned)
This was my first PR with Ansible project, so I'm not sure what to do next.

@Akasurde
Copy link
Member

Akasurde commented Jan 2, 2024

still, this requires a changelog

Do I need to add anything to this PR?(regarding the changelog you mentioned) This was my first PR with Ansible project, so I'm not sure what to do next.

You can create a changelog fragment in this same PR. See this fragment as an example.

@inntran
Copy link
Contributor Author

inntran commented Jan 3, 2024

@Akasurde I have added a changelog fragment.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 5, 2024
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 9, 2024
@bcoca bcoca merged commit 0a45dad into ansible:devel Jan 9, 2024
62 checks passed
@ansible ansible locked and limited conversation to collaborators Feb 6, 2024
@inntran inntran deleted the vmware20_1-detection branch March 13, 2024 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants