Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-config dedupe ini plugin entries #82498

Merged
merged 3 commits into from Jan 9, 2024
Merged

ansible-config dedupe ini plugin entries #82498

merged 3 commits into from Jan 9, 2024

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jan 8, 2024

fixes #82481

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. has_issue labels Jan 8, 2024
@bcoca bcoca marked this pull request as ready for review January 8, 2024 16:43
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 8, 2024
@ansible ansible deleted a comment from ansibot Jan 8, 2024
@bcoca
ansible-config dedupe ini plugin entries
c5e950c 
 added test for ini file integrity, also ensuring no dupes
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Jan 8, 2024
jborean93
jborean93 reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits in the testing side.

test/integration/targets/ansible-config/tasks/main.yml Outdated Show resolved Hide resolved
test/sanity/ignore.txt Outdated Show resolved Hide resolved
test/integration/targets/ansible-config/tasks/main.yml Show resolved Hide resolved
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 9, 2024
@bcoca bcoca merged commit 6c2895f into ansible:devel Jan 9, 2024
62 checks passed
@bcoca bcoca deleted the config_no_dupes branch January 9, 2024 17:07
bcoca added a commit to bcoca/ansible that referenced this pull request Jan 9, 2024
@bcoca
ansible-config dedupe ini plugin entries (ansible#82498)
64977dd 
 added test for ini file integrity, also ensuring no dupes

(cherry picked from commit 6c2895f)
bcoca added a commit to bcoca/ansible that referenced this pull request Jan 9, 2024
@bcoca
ansible-config dedupe ini plugin entries (ansible#82498)
8553a5f 
 added test for ini file integrity, also ensuring no dupes

(cherry picked from commit 6c2895f)
mattclay pushed a commit that referenced this pull request Jan 19, 2024
@bcoca @mattclay
ansible-config dedupe ini plugin entries (#82498)
46d9d4b 
 added test for ini file integrity, also ensuring no dupes

(cherry picked from commit 6c2895f)
mattclay pushed a commit that referenced this pull request Jan 19, 2024
@bcoca @mattclay
ansible-config dedupe ini plugin entries (#82498)
74869eb 
 added test for ini file integrity, also ensuring no dupes

(cherry picked from commit 6c2895f)
@ansible ansible locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. has_issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-config init -t all generate many multiple duplicate option
3 participants
@bcoca @jborean93 @ansibot