Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid winrm hang on stdin write failure #82766

Merged
merged 1 commit into from Mar 6, 2024
Merged

Avoid winrm hang on stdin write failure #82766

merged 1 commit into from Mar 6, 2024

Conversation

jborean93
Copy link
Contributor

SUMMARY

If the connection plugin fails to write the data to run to stdin we will only attempt to get the output with one operation attempt. If this times out we will consider the command to have failed and raise an exception instead of forever attempting to get the output.

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 3, 2024
@ansibot
Copy link
Contributor

ansibot commented Mar 3, 2024

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/connection/winrm.py:192:0: unused-import: Unused binary_type imported from ansible.module_utils.six

click here for bot help

@jborean93
Avoid winrm hang on stdin write failure
1e78427 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 4, 2024
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2024
@jborean93 jborean93 marked this pull request as ready for review March 6, 2024 18:40
@jborean93 jborean93 merged commit 942424e into ansible:devel Mar 6, 2024
62 checks passed
@jborean93 jborean93 deleted the winrm-input branch March 6, 2024 22:47
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 6, 2024
@jborean93
Avoid winrm hang on stdin write failure (ansible#82766)
a3816a1 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.

(cherry picked from commit 942424e)
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 6, 2024
@jborean93
Avoid winrm hang on stdin write failure (ansible#82766)
359e046 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.

(cherry picked from commit 942424e)
@jborean93
Copy link
Contributor Author

Backport PRs

jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 6, 2024
@jborean93
Avoid winrm hang on stdin write failure (ansible#82766)
08eabc5 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.

(cherry picked from commit 942424e)
sivel pushed a commit that referenced this pull request Mar 13, 2024
@jborean93
Avoid winrm hang on stdin write failure (#82766) (#82781)
8190a2a 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.

(cherry picked from commit 942424e)
sivel pushed a commit that referenced this pull request Mar 13, 2024
@jborean93
Avoid winrm hang on stdin write failure (#82766) (#82782)
0756237 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.

(cherry picked from commit 942424e)
bcoca pushed a commit to bcoca/ansible that referenced this pull request Mar 19, 2024
@jborean93 @bcoca
Avoid winrm hang on stdin write failure (ansible#82766)
7ff5ce1 
If the connection plugin fails to write the data to run to stdin we will
only attempt to get the output with one operation attempt. If this times
out we will consider the command to have failed and raise an exception
instead of forever attempting to get the output.
@ansible ansible locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @ansibot @nitzmahone @mkrizek