Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.17] facts: Add a generic detection for VMware product name #83023

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Use startswith instead of hardcoded values in VMWare product
    detction

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request

* Use startswith instead of hardcoded values in VMWare product
  detction

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. backport This PR does not target the devel branch. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 11, 2024
@webknjaz
Copy link
Member

TODO: re-run the CI once #83025 is merged

@Akasurde
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 12, 2024
@mattclay mattclay changed the title [bp-2.17] facts: Add a generic detection for VMware product name [stable-2.17] facts: Add a generic detection for VMware product name Apr 15, 2024
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Apr 15, 2024
@mattclay mattclay merged commit ad2a1a5 into ansible:stable-2.17 Apr 15, 2024
67 checks passed
@ansible ansible locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants