Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: Bind Mount repeats mount command when using a bind mount #8422

Closed
fti7 opened this issue Aug 4, 2014 · 2 comments
Closed

mount: Bind Mount repeats mount command when using a bind mount #8422

fti7 opened this issue Aug 4, 2014 · 2 comments
Labels
bug This issue/PR relates to a bug.

Comments

@fti7
Copy link
Contributor

fti7 commented Aug 4, 2014

Issue Type:

Bug Report

Ansible Version:

ansible 1.7 (devel 189824d) last updated 2014/07/30 17:24:01 (GMT +200)

Environment:

Ubuntu 12.04 LTS

Summary:

The Mount Module is not idempotent if you are using an Bindmount with state=mounted.
It mounts it on every run

Steps To Reproduce:
- name: BIND MOUNT | /usr/local/jdk1.7 -> /usr/lib/jvm/java-7-oracle
  mount: 
    name=/usr/local/jdk1.7
    src='/usr/lib/jvm/java-7-oracle' 
    fstype=none
    opts=bind
    state=mounted

(No, i wont use Symlinks for this)

Expected Results:

Correct checking of the Mount Status and just execute it once if neccessary

Actual Results:

3x Run, 3x "Changed" ->
$ mount
/usr/lib/jvm/java-7-oracle on /usr/local/jdk1.7 type none (rw,bind)
/usr/lib/jvm/java-7-oracle on /usr/local/jdk1.7 type none (rw,bind)
/usr/lib/jvm/java-7-oracle on /usr/local/jdk1.7 type none (rw,bind)

@mpdehaan mpdehaan changed the title mount: Bind Mount without Idempotence mount: Bind Mount repeats mount command when using a bind mount Aug 4, 2014
@Jmainguy
Copy link
Contributor

Jmainguy commented Aug 8, 2014

This appears to be a duplicate of #7121. The issue comes down to python's os.path.ismount() does not recognize bind mounts as mounts.

@mpdehaan
Copy link
Contributor

Hi!

Thanks very much for your interest in Ansible. It sincerely means a lot to us.

On September 26, 2014, due to enormous levels of contribution to the project Ansible decided to reorganize module repos, making it easier
for developers to work on the project and for us to more easily manage new contributions and tickets.

We split modules from the main project off into two repos, http://github.com/ansible/ansible-modules-core and http://github.com/ansible/ansible-modules-extras

If you would still like this ticket attended to, we will need your help in having it reopened in one of the two new repos, and instructions are provided below.

We apologize that we are not able to make this transition happen seamlessly, though this is a one-time change and your help is greatly appreciated --
this will greatly improve velocity going forward.

Both sets of modules will ship with Ansible, though they'll receive slightly different ticket handling.

To locate where a module lives between 'core' and 'extras'

Additionally, should you need more help with this, you can ask questions on:

Thank you very much!

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants