Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As of 1.7.2 lineinfile not inserting double single quotes #9171

Closed
PriceChild opened this issue Sep 26, 2014 · 2 comments
Closed

As of 1.7.2 lineinfile not inserting double single quotes #9171

PriceChild opened this issue Sep 26, 2014 · 2 comments
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release

Comments

@PriceChild
Copy link
Contributor

Issue Type:

Bug Report

Ansible Version:

1.7.2

Environment:

Debian Sid

Summary:

Using the gist at https://gist.github.com/anonymous/dc1de03995dc9ae147af in ansible 1.7.1 correctly forces a line with synchronous_standby_names='' in it.

With 1.7.2, it enforces a line with synchronous_standby_names=.

I have confirmed it is definitely a difference between 1.7.1 & 1.7.2 by swapping between:
sudo dpkg -i /var/cache/apt/archives/ansible_1.7.1+dfsg-1_all.deb
sudo dpkg -i /var/cache/apt/archives/ansible_1.7.2+dfsg-1_all.deb

Looking at the patches debian applies, that shouldn't be related. Time for a git bisect!

Steps To Reproduce:

Use the task in the linked gist.

Expected Results:

A line with synchronous_standby_names='' should appear in the file.

Actual Results:

synchronous_standby_names= appears in the file.

@PriceChild PriceChild changed the title lineinfile not inserting double single quotes As of 1.7.2 lineinfile not inserting double single quotes Sep 26, 2014
@jimi-c jimi-c added P3 labels Sep 26, 2014
@mpdehaan mpdehaan added P2 Priority 2 - Issue Blocks Release and removed P3 labels Sep 28, 2014
@PriceChild
Copy link
Contributor Author

Checked out master and found the issue has already been resolved!

Ran a git bisect and found the fixing commit was 085ba4f so it turns out this issue is a duplicate of #8806

Edit: I must be using git bisect incorrectly... that commit was included in v1.7.2? I'll see if I can figure out what's up and report back. It'd be nice to have this fixed for 1.7 rather than 1.8?

@mpdehaan
Copy link
Contributor

Hi!

Thanks very much for your interest in Ansible. It sincerely means a lot to us.

On September 26, 2014, due to enormous levels of contribution to the project Ansible decided to reorganize module repos, making it easier
for developers to work on the project and for us to more easily manage new contributions and tickets.

We split modules from the main project off into two repos, http://github.com/ansible/ansible-modules-core and http://github.com/ansible/ansible-modules-extras

If you would still like this ticket attended to, we will need your help in having it reopened in one of the two new repos, and instructions are provided below.

We apologize that we are not able to make this transition happen seamlessly, though this is a one-time change and your help is greatly appreciated --
this will greatly improve velocity going forward.

Both sets of modules will ship with Ansible, though they'll receive slightly different ticket handling.

To locate where a module lives between 'core' and 'extras'

Additionally, should you need more help with this, you can ask questions on:

Thank you very much!

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Projects
None yet
Development

No branches or pull requests

4 participants