Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 is returning success when a module raises an uncaught exception #10549

Closed
abadger opened this issue Mar 26, 2015 · 1 comment
Closed

v2 is returning success when a module raises an uncaught exception #10549

abadger opened this issue Mar 26, 2015 · 1 comment
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Milestone
2.0

Comments

@abadger
Copy link
Contributor

abadger commented Mar 26, 2015

If you modify v2/ansible/modules/core/system/ping.py like this:

diff --git a/system/ping.py b/system/ping.py
index b098d00..2fefc9b 100644
--- a/system/ping.py
+++ b/system/ping.py
@@ -40,6 +40,7 @@ ansible webservers -m ping
 import exceptions

 def main():
+    raise Exception('You should see me!')
     module = AnsibleModule(
         argument_spec = dict(
             data=dict(required=False, default=None),

and then run v2's ansible you'd expect an error. Instead you get a success message:

$ ansible localhost -c local -m ping -a 'you=wouldexpectanerror'
localhost | SUCCESS => {
    "invocation": {
        "module_name": "ping", 
        "module_args": {
            "you": "wouldexpectanerror"
        }
    }, 
    "changed": false
}
@abadger abadger added this to the v2 milestone Mar 26, 2015
@bcoca bcoca added bug_report P2 Priority 2 - Issue Blocks Release labels Mar 30, 2015
@jimi-c jimi-c closed this as completed in c58aaf7 Apr 21, 2015
@jimi-c
Copy link
Member

jimi-c commented Apr 21, 2015

Closing This Ticket

Hi!

We believe the above commit should resolve this problem for you. This will also be included in the next major release.

If you continue seeing any problems related to this issue, or if you have any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:

Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular issue is resolved.

Thank you!

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@jimi-c @abadger @bcoca @ansibot