Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle Linux no longer detected as a Red Hat clone #10742

Closed
mavit opened this issue Apr 16, 2015 · 4 comments · Fixed by #10789
Closed

Oracle Linux no longer detected as a Red Hat clone #10742

mavit opened this issue Apr 16, 2015 · 4 comments · Fixed by #10789
Labels
bug This issue/PR relates to a bug.

Comments

@mavit
Copy link
Contributor

mavit commented Apr 16, 2015

Issue Type:

Bug Report

Ansible Version:
ansible 1.9.0.1
  configured module search path = None
Environment:

Oracle Linux Server release 7.1

Summary:

Oracle Linux is (mostly) built from the same SRPMs as Red Hat Enterprise Linux, so the ansible_os_family fact should be set to RedHat. This used to work in Ansible 1.8.

I believe that this is a consequence of pull #10508.

Steps To Reproduce:
ansible -m setup localhost | grep os_family
Expected Results:
        "ansible_os_family": "RedHat",
Actual Results:
        "ansible_os_family": "Oracle Linux",
@william20111
Copy link

is this actually a bug? Like you said its mostly built from same SRPMs. And you can run the unbreakable kernel which is vastly different. I think current results are correct.

@bcoca
Copy link
Member

bcoca commented Apr 16, 2015

closing this as we do not consider it a bug but a work around Oracle misrepresentation.

@bcoca bcoca closed this as completed Apr 16, 2015
mavit added a commit to mavit/ansible that referenced this issue Apr 19, 2015
@mavit
Consistently use "OracleLinux" in OS detection.
d8be6fe 
Previously, a mixture of "OracleLinux" and "Oracle Linux" was used,
causing the `ansible_os_family` fact not to be set to `RedHat`.

Fixes ansible#10742.
@mavit
Copy link
Contributor Author

mavit commented Apr 19, 2015

If this is the expected behaviour, then what is the ansible_os_family fact supposed to be for? It's set to RedHat on both CentOS (which is very similar to Oracle Linux) and Fedora (which is significantly different to RHEL). We have another fact, ansible_distribution, for telling these distributions apart from each other.

By the way, I have commit d8be6fe which I'm happy to turn into a pull request if you reconsider.

@bcoca bcoca reopened this Apr 20, 2015
@bcoca
Copy link
Member

bcoca commented Apr 20, 2015

sorry, mixed things, yes, family should still be redhat but distro must be oracle linux.

@mavit mavit mentioned this issue Apr 20, 2015
Merged
bcoca pushed a commit that referenced this issue Apr 20, 2015
@mavit @bcoca
Consistently use "OracleLinux" in OS detection.
3a5a668 
Previously, a mixture of "OracleLinux" and "Oracle Linux" was used,
causing the `ansible_os_family` fact not to be set to `RedHat`.

Fixes #10742.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistently use "OracleLinux" in OS detection. mavit/ansible
4 participants
@mavit @bcoca @william20111 @ansibot