Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make test_galaxy fails #11486

Closed
willthames opened this issue Jul 4, 2015 · 2 comments · Fixed by #12861
Closed

make test_galaxy fails #11486

willthames opened this issue Jul 4, 2015 · 2 comments · Fixed by #12861
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Milestone
2.0

Comments

@willthames
Copy link
Contributor

A lot of code that was at the heart of ansible-galaxy has been ripped out and not replaced.

This means that make test_galaxy trivially fails

We need something to replace ansible.utils.role_yaml_parse and ansible.utils.role_spec_parse, and make test_galaxy should pass its tests (those tests exist for a reason!)
@bcoca
Copy link
Member

bcoca commented Jul 4, 2015

i'm still in the process of reworking the interaction with roles for the install function, most of the other functionality is there.

@bcoca bcoca added bug_report P2 Priority 2 - Issue Blocks Release labels Jul 4, 2015
@bcoca bcoca added this to the v2 milestone Jul 4, 2015
@bcoca
Copy link
Member

bcoca commented Jul 4, 2015

closing as dupe of #11179

@bcoca bcoca closed this as completed Jul 4, 2015
@willthames willthames mentioned this issue Sep 28, 2015
Closed
semifocused added a commit to 47lining/ansible that referenced this issue Sep 28, 2015
@semifocused
Additional role installation mods towards making @willthames galaxy t…
cb60a14 
…ests pass. It appears that all roles are installed as intended, but an ansible playbook issue remains when finding dependent roles. Partially addresses ansible#11486.
willthames added a commit to willthames/ansible that referenced this issue Oct 22, 2015
@willthames
Allow meta/main.yml to include roles through spec file
002972c 
ansible-playbook now works when run with a playbook
that includes a role that includes another role
specified using csv format

Updated one of the roles used in the tests to fix
broken tests - `make test_galaxy` now works

Fixes ansible#11486. Also addresses the problem alluded to in ansible#10620.
@willthames willthames mentioned this issue Oct 22, 2015
Merged
photoninger pushed a commit to photoninger/ansible that referenced this issue Oct 26, 2015
@willthames @photoninger
Allow meta/main.yml to include roles through spec file
111013c 
ansible-playbook now works when run with a playbook
that includes a role that includes another role
specified using csv format

Updated one of the roles used in the tests to fix
broken tests - `make test_galaxy` now works

Fixes ansible#11486. Also addresses the problem alluded to in ansible#10620.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Allow meta/main.yml to include roles through spec file willthames/ansible
3 participants
@willthames @bcoca @ansibot