Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port modules from type=str to type=path #12263

Closed
abadger opened this issue Sep 6, 2015 · 0 comments
Closed

Port modules from type=str to type=path #12263

abadger opened this issue Sep 6, 2015 · 0 comments
Labels
affects_2.1 This issue/PR affects Ansible v2.1 affects_2.3 This issue/PR affects Ansible v2.3 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@abadger
Copy link
Contributor

abadger commented Sep 6, 2015 •
edited by ansibot

ISSUE TYPE

Feature Idea

COMPONENT NAME

core

ANSIBLE VERSION

2.1

CONFIGURATION
OS / ENVIRONMENT
SUMMARY

In both the core and extras repositories we have modules that take a file system path as a parameter. In the past each module needed to expanduser and expandvars on those to expand things like "~" and "$HOME". In 2.0 we added a new type to the argument spec: path. We need to port all of the modules to use that instead (change the argument_spaec to switch from type="str", the default, to type="path" and change the code to not run expanduser and expandvars on the path a second time.)

A good first approximation of the work is seen via: grep -r expanduser lib/ansible/modules

STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
@jimi-c jimi-c removed the P3 label Dec 7, 2015
@lloydhazlett lloydhazlett mentioned this issue Feb 14, 2016
Merged
@ansibot ansibot added triage affects_2.1 This issue/PR affects Ansible v2.1 labels Sep 7, 2016
@ansibot ansibot added the affects_2.3 This issue/PR affects Ansible v2.3 label Dec 13, 2016
@bcoca bcoca removed the triage label Dec 16, 2016
@caphrim007 caphrim007 mentioned this issue Feb 11, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 11, 2017
@caphrim007
Adds path type and remove expanduser
8a30c05 
Related to ansible#12263, this patch removes the usage of expanduser
in favor of the path 'type' for the module options of src and
dest
@caphrim007 caphrim007 mentioned this issue Feb 11, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 11, 2017
@caphrim007
Remove expanduser and use type path
7b66e7b 
This patch removes the use of expanduser and replaces it with
type 'path'. This patch is related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Feb 12, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 12, 2017
@caphrim007
Replace expanduser with type path
bfc54ef 
This patch removes the use of expanduser and replaces it with
type 'path' for the option. This is related to ansible#12263.
@caphrim007 caphrim007 mentioned this issue Feb 12, 2017
Merged
bcoca pushed a commit that referenced this issue Feb 13, 2017
@caphrim007 @bcoca
Replace expanduser with type path
0fcc6ed 
This patch removes the use of expanduser and replaces it with
type 'path' for the option. This is related to #12263.
bcoca pushed a commit that referenced this issue Feb 13, 2017
@caphrim007 @bcoca
Adds path type and remove expanduser
c4d3bf3 
Related to #12263, this patch removes the usage of expanduser
in favor of the path 'type' for the module options of src and
dest
bcoca pushed a commit that referenced this issue Feb 13, 2017
@caphrim007 @bcoca
Remove expanduser and use type path
4900201 
This patch removes the use of expanduser and replaces it with
type 'path'. This patch is related to #12263
@caphrim007 caphrim007 mentioned this issue Feb 13, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 13, 2017
@caphrim007
Replaces expanduser with type path
03cb05a 
Replaces the usage of expanduser with the type 'path' for the
dest and object options as that functionality is available
in that type automatically.

patch related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Feb 13, 2017
Merged
bcoca pushed a commit that referenced this issue Feb 13, 2017
@caphrim007 @bcoca
Replaces expanduser with type path
bf83685 
Replaces the usage of expanduser with the type 'path' for the
dest and object options as that functionality is available
in that type automatically.

patch related to #12263
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 13, 2017
@caphrim007
Removes expanduser in favor of type path
984c71d 
Removes the usage of expanduser in favor of the type 'path' for
module options. Related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Feb 13, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 13, 2017
@caphrim007
Removes expanduser calls
2a21dce 
The usage of type='path' includes the expanduser call itself. This
patch removes its duplicate usage. Related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Feb 13, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 14, 2017
@caphrim007
Removes expanduser in favor of type path
40f24b8 
Removes the usage of expanduser because it is handled automatically
by type 'path'. Related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Feb 14, 2017
Merged
caphrim007 added a commit to caphrim007/ansible that referenced this issue Feb 14, 2017
@caphrim007
Removes expanduser in favor of type 'path'
eb70a10 
Removes the usage of expanduser because it is automatically handed
by specifying a type of 'path'. Related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Feb 14, 2017
Merged
ryansb pushed a commit that referenced this issue Feb 14, 2017
@caphrim007 @ryansb
[cloud][serverless] Removes manual expanduser call in favor of type `…
5f01cd4 
…path` (#21418)

Removes the usage of expanduser because it is handled automatically
by type 'path'. Related to #12263
bcoca pushed a commit that referenced this issue Feb 14, 2017
@caphrim007 @bcoca
Removes expanduser in favor of type 'path'
2292608 
Removes the usage of expanduser because it is automatically handed
by specifying a type of 'path'. Related to #12263
bcoca pushed a commit that referenced this issue Feb 27, 2017
@caphrim007 @bcoca
Removes expanduser calls
888c861 
The usage of type='path' includes the expanduser call itself. This
patch removes its duplicate usage. Related to #12263
caphrim007 added a commit to caphrim007/ansible that referenced this issue Mar 6, 2017
@caphrim007
Removes expanduser in favor of type path
9da11f4 
Removes the usage of expanduser in favor of the type 'path' for
module options. Related to ansible#12263
@caphrim007 caphrim007 mentioned this issue Mar 6, 2017
Merged
sivel pushed a commit that referenced this issue Mar 30, 2017
@caphrim007 @sivel
Removes expanduser in favor of type path (#21369)
2bf7297 
Removes the usage of expanduser in favor of the type 'path' for
module options. Related to #12263
bcoca pushed a commit that referenced this issue Mar 31, 2017
@caphrim007 @bcoca
Removes expanduser in favor of type path
e27b4c2 
Removes the usage of expanduser in favor of the type 'path' for
module options. Related to #12263
@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Apr 4, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@calfonso calfonso closed this as completed Oct 5, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_idea labels Mar 2, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.1 This issue/PR affects Ansible v2.1 affects_2.3 This issue/PR affects Ansible v2.3 feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@calfonso @jimi-c @abadger @bcoca @ansibot