Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strategy free exits with code 1 #18023

Closed
kamsz opened this issue Oct 14, 2016 · 2 comments
Closed

Strategy free exits with code 1 #18023

kamsz opened this issue Oct 14, 2016 · 2 comments
Assignees
@jimi-c
Labels
affects_2.2 This issue/PR affects Ansible v2.2 bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release

Comments

@kamsz
Copy link

kamsz commented Oct 14, 2016

ISSUE TYPE
  • Bug Report
COMPONENT NAME

free strategy

ANSIBLE VERSION
root@mbn:~/nimis/ansible# ansible --version
ansible 2.2.0.0
  config file = /root/ansible/ansible.cfg
  configured module search path = Default w/o overrides
CONFIGURATION
[defaults]
#callback_plugins=callback_plugins
#callback_whitelist=timer,profile_tasks
fact_caching_connection=ansible_facts.json
fact_caching_timeout=600
fact_caching=jsonfile
forks=100
gathering=smart
host_key_checking=False
remote_user=root
retry_files_enabled=False

[ssh_connection]
retries=5
ssh_args=-o ControlMaster=auto -o ControlPersist=300s -o UserKnownHostsFile=/dev/null
pipelining=True
OS / ENVIRONMENT

Ubuntu 16.04

SUMMARY

When using strategy: free all playbooks exit with code 1. After changing the strategy to default, a proper exit code (0) is returned.

STEPS TO REPRODUCE

---
- hosts: localhost
  strategy: free
  tasks:
    - debug: msg='test'

root@mbn:~/ansible# echo $?
1


---
- hosts: localhost
  #strategy: free
  tasks:
    - debug: msg='test'

root@mbn:~/ansible# echo $?
0

EXPECTED RESULTS

Running playbook with strategy free should exit with 0 when playbook has executed successfully.

ACTUAL RESULTS

Running playbook with strategy free exists with exit code 1.
@ansibot ansibot added bug_report affects_2.2 This issue/PR affects Ansible v2.2 labels Oct 14, 2016
@jctanner
Copy link
Contributor

jctanner commented Oct 14, 2016 •
edited

I was able to reproduce with devel -and- 2.2rc1

v2.0.1.0-0.1.rc1 ; 0
v2.0.1.0-0.2.rc2 ; 0
v2.0.1.0-1 ; 0
v2.0.2.0-0.1.rc1 ; 0
v2.0.2.0-0.2.rc2 ; 0
v2.0.2.0-0.3.rc3 ; 0
v2.0.2.0-0.4.rc4 ; 0
v2.0.2.0-1 ; 0
v2.1.0.0-0.1.rc1 ; 0
v2.1.0.0-0.2.rc2 ; 0
v2.1.0.0-0.3.rc3 ; 0
v2.1.0.0-0.4.rc4 ; 0
v2.1.0.0-1 ; 0
v2.1.1.0-0.1.rc1 ; 0
v2.1.1.0-0.2.rc2 ; 0
v2.1.1.0-0.3.rc3 ; 0
v2.1.1.0-0.4.rc4 ; 0
v2.1.1.0-0.5.rc5 ; 0
v2.1.1.0-1 ; 0
v2.1.2.0-0.1.rc1 ; 0
v2.1.2.0-0.2.rc2 ; 0
v2.1.2.0-0.3.rc3 ; 0
v2.1.2.0-0.4.rc4 ; 0
v2.1.2.0-0.5.rc5 ; 0
v2.1.2.0-1 ; 0
v2.2.0.0-0.1.rc1; 1
devel-8095c39 ; 1

@jctanner jctanner added the P2 Priority 2 - Issue Blocks Release label Oct 14, 2016
jimi-c added a commit that referenced this issue Oct 14, 2016
@jimi-c
Make sure free strategy is returning proper TQM constants
b8c25d8 
Fixes #18023

(cherry picked from commit 6bdcb3a)
@jimi-c jimi-c closed this as completed in 6bdcb3a Oct 14, 2016
@jimi-c
Copy link
Member

jimi-c commented Oct 14, 2016

Closing This Ticket

Hi!

We believe the above commit should resolve this problem for you. This will also be included in the next release.

If you continue seeing any problems related to this issue, or if you have any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:

Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular issue is resolved.

Thank you!

sereinity pushed a commit to sereinity-forks/ansible that referenced this issue Jan 25, 2017
@jimi-c
Make sure free strategy is returning proper TQM constants
d07998b 
Fixes ansible#18023

(cherry picked from commit 6bdcb3a)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jimi-c jimi-c

Labels
affects_2.2 This issue/PR affects Ansible v2.2 bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jimi-c @jctanner @kamsz @ansibot