Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows module win_get_url don't use proxy when "force: no" used #22126

Closed
ar7z1 opened this issue Mar 1, 2017 · 3 comments
Closed

Windows module win_get_url don't use proxy when "force: no" used #22126

ar7z1 opened this issue Mar 1, 2017 · 3 comments
Assignees
@jhawkesworth
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. module This issue/PR relates to a module. windows Windows community

Comments

@ar7z1
Copy link
Contributor

ar7z1 commented Mar 1, 2017

ISSUE TYPE
  • Bug Report
COMPONENT NAME

windows/win_get_url

ANSIBLE VERSION
ansible 2.3.0 (win_get_url_force_with_proxy 76c46e9039) last updated 2017/03/01 12:57:19 (GMT +300)
  config file = /home/art/.ansible.cfg
  configured module search path = Default w/o overrides
CONFIGURATION
OS / ENVIRONMENT

N/A

SUMMARY

Windows module win_get_url don't use proxy when force: no used.

STEPS TO REPRODUCE
- name: Download earthrise.jpg to specified path through a proxy server only if modified.
  win_get_url:
    url: http://www.example.com/earthrise.jpg
    dest: C:\Users\RandomUser\earthrise.jpg
    force: no
    proxy_url: http://10.0.0.1:8080
    proxy_username: username
    proxy_password: password
EXPECTED RESULTS
ACTUAL RESULTS

Got an error:

fatal: [host]: FAILED! => {"changed": false, "failed": true, "msg": "Error when requesting Last-Modified date from http://www.example.com/earthrise.jpg Exception calling \"GetResponse\" with \"0\" argument(s): \"The remote server returned an error: (407) Proxy Authentication Required.\"", "win_get_url": {"dest": "C:\\Users\\RandomUser\\earthrise.jpg", "url": "http://www.example.com/earthrise.jpg"}}
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2017

cc @jhawkesworth
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bug_report module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. windows Windows community labels Mar 1, 2017
ar7z1 added a commit to ar7z1/ansible that referenced this issue Mar 1, 2017
@ar7z1
Fix ansible#22126
d8d00b0
@ar7z1
Copy link
Contributor Author

ar7z1 commented Mar 1, 2017

Fixed in #22128.

@jctanner jctanner removed the needs_triage Needs a first human triage before being processed. label Mar 3, 2017
@jhawkesworth
Copy link
Contributor

Your fix #22128 is awaiting core review.

nitzmahone pushed a commit that referenced this issue Mar 29, 2017
@ar7z1 @nitzmahone
Fix #22126 (#22128)
7c84593 
(cherry picked from commit a5da638)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhawkesworth jhawkesworth

Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. module This issue/PR relates to a module. windows Windows community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jctanner @ar7z1 @ansibot @jhawkesworth