-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scripts dir in roles #2969
Comments
+1 |
I think this should be possible. Patches would be accepted. Leaving this open. |
This is something I was just wishing for the other day too, great to see it! My only comment would be whether it makes more sense to search for these scripts in roles/$role/files instead of a new subdirectory called scripts? In my case I would rather have them in files/ because then you wouldn't have to duplicate file between scripts/ and files/ if you sometimes wanted to use it with copy and sometimes with script... |
@mcodd having a separate scripts/ directory is conform files/ and templates/; I used to put regular files in templates/ to (before we had roles), but with roles, it makes more sense to standardize, imho. Also, I'm not sure what your use case would be to use the same file both as a script resource, and as a files (or even templates) resource? The same goes for e.g. tasks (or files or templates, ..) you'd use in several roles. As to not duplicate the content, I keep a master file at a certain place, and just symlink them if I have to reuse them. |
I would also be inclined to agree with mcodd here, we are copying these It should still also fallback to looking in the current spot as I mentioned On Sat, May 25, 2013 at 9:52 AM, Serge van Ginderachter <
|
OK for me. |
allows to put scripts directly in a dir within the role: roles/<role>/scripts/.. Same as the copy and template module. As requested in and closes #2969
Could we extend roles to support scripts?
So
Gets automagically sucked up from, roles/myrole/scripts/myscript.sh
?
The text was updated successfully, but these errors were encountered: