Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yum_repository includepkgs parameter break repo file #32704

Closed
ssbarnea opened this issue Nov 8, 2017 · 5 comments
Closed

yum_repository includepkgs parameter break repo file #32704

ssbarnea opened this issue Nov 8, 2017 · 5 comments
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Nov 8, 2017

ISSUE TYPE
  • Bug Report
COMPONENT NAME

yum_repository

ANSIBLE VERSION
2.4.1.0
CONFIGURATION

N/A

OS / ENVIRONMENT

N/A

SUMMARY

If you specify multiple packages to include Ansible will write the list as Python list inside the repo file and make it unreadable by YUM.

STEPS TO REPRODUCE
  yum_repository:
    name: '{{ item }}'
    includepkgs:
    - foo
    - bar
EXPECTED RESULTS

repo file should contain this line:

includepkgs=foo bar
ACTUAL RESULTS

repo file will include this invalid line:

includepkgs = ['foo', 'bar']

Documentation states explicitly that use of YAML lists is accepted but the reality is very different.
@ansibot
Copy link
Contributor

ansibot commented Nov 8, 2017

cc @jtyr
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bug_report module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 8, 2017
@jtyr
Copy link
Contributor

jtyr commented Nov 8, 2017

Thanks for reporting this. I will provide a fix for this shortly.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 8, 2017
@jtyr jtyr mentioned this issue Nov 8, 2017
Merged
jtyr added a commit to jtyr/ansible that referenced this issue Nov 9, 2017
@jtyr
Making options of type list (fixing ansible#32704)
dc6eb0b
@alikins alikins changed the title yum_repository includepkgs parameter brake repo file yum_repository includepkgs parameter break repo file Nov 9, 2017
@k0ste
Copy link
Contributor

k0ste commented Nov 20, 2017

Also affects_2.3.
Fix works, thanks.

@Akasurde
Copy link
Member

Closing this issue as PR is merged. If issue persists, please feel free to re-open.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ssbarnea
Copy link
Member Author

Please merge this fix to 2.4.x stable.

@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ssbarnea @Akasurde @jtyr @ansibot @k0ste