-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ansible-pull to support other repository types #3372
Labels
feature
This issue/PR relates to a feature request.
Comments
Looking forward to this! |
We already have a pull request for this, so I am going to close the ticket, the PR is very likely to be merged and this keeps it easier to organize github. |
jimi-c
pushed a commit
that referenced
this issue
Aug 20, 2013
For issue #3372, apply consistent parameter aliases to source_control modules. For hg, add name and version and add to documentation string. For subversion, add version and document version and name aliases in documentation string.
jimi-c
pushed a commit
that referenced
this issue
Aug 20, 2013
This extends ansible-pull so that it can support using other source_control modules for checking out a playbook repository (issue #3372). This will check to see if the module exists before it attempts to do the checkout and will exit if the module is not found. It requires that the module used to check out the repository support the parameters 'name' and 'version'. The option -C, --checkout is now optional and defaults to the module's default behavior for selecting a branch, tag, or commit value. For git, this continues to be HEAD. Other changes include: * Remove git from help and use generic term(s) where needed. * Use SortedOptParser from ansible.utils * More abstraction of common options used between ansible and ansible-playbook.
jimi-c
pushed a commit
that referenced
this issue
Aug 20, 2013
jimi-c
pushed a commit
that referenced
this issue
Dec 6, 2016
robinro
pushed a commit
to robinro/ansible
that referenced
this issue
Dec 9, 2016
ansibot
added
feature
This issue/PR relates to a feature request.
and removed
feature_idea
labels
Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are requests for ansible-pull to support other source repositories such as mercurial. I propose adding support to extending ansible-pull to support other repositories, as long as there is a module for it.
As an aside, there was a request for s3 support. However, the s3 module is for putting a file in s3 and not for downloading.
One thing that would help is if the source_control modules were a bit more consistent about parameter names. As part of this change, I propose make name an alias for repo (if not already present) and version an alias for revision. Modules that need the name alias: hg. Modules that need the version alias: subversion, hg.
I've started some preliminary work on this. Any comments on the above, before I submit a PR?
The text was updated successfully, but these errors were encountered: