Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2 module incorrectly returns changed=True when there is no change #3746

Closed
lorin opened this issue Aug 3, 2013 · 1 comment · Fixed by #3747
Closed

ec2 module incorrectly returns changed=True when there is no change #3746

lorin opened this issue Aug 3, 2013 · 1 comment · Fixed by #3747
Labels
bug This issue/PR relates to a bug.

Comments

@lorin
Copy link
Contributor

lorin commented Aug 3, 2013

If I invoke the ec2 module multiple times with the id parameter set, then it will return changed=True every time, even if there are no changes on the subsequent calls.

It looks like the module is hard-coded to always return changed=True.
@lorin lorin mentioned this issue Aug 3, 2013
Merged
@mpdehaan
Copy link
Contributor

mpdehaan commented Aug 3, 2013

Thanks for this.

BTW, if you are going to submit a PR there is no need to also open the other ticket, leaves me with 2x the tickets in the queue since the PR is also a ticket.

mpdehaan pushed a commit that referenced this issue Aug 3, 2013
ec2: check for changes
0c1f6b4 
In the ec2 module, if an id is specified, check if there have been
any changes. If not, return changed=False

Fixes #3746
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec2: check for changes lorin/ansible
3 participants
@mpdehaan @lorin @ansibot