Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to python3 on Debian 10 #63097

Merged
merged 4 commits into from Nov 14, 2019
Merged

Default to python3 on Debian 10 #63097

merged 4 commits into from Nov 14, 2019

Conversation

johnbui423
Copy link
Contributor

@johnbui423 johnbui423 commented Oct 3, 2019 •
edited

SUMMARY

For Debian 10, I propose to default to python3 when using ansible_python_interpreter = auto.
Like Ubuntu 16, Debian 9 comes with both python2 and python3. Again like Ubuntu 16, I propose to default to python3 when using ansible_python_interpreter = auto.

People that want to stick to the python 2, can set ansible_python_interpreter = auto_legacy to default to python 2 (which is currently still the default setting).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

BaseAction

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 3, 2019
@sivel
Copy link
Member

sivel commented Oct 3, 2019

The default python version on Debian 9 is Python 2.7. As such, I don't think this change should be made.

https://wiki.debian.org/Python#Supported_Python_Versions

Debian Stretch contains Python 2.7 (default), 3.5

Buster (10) is the first version of Debian to default to Python3.

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Oct 3, 2019
ghost
ghost suggested changes Oct 9, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbui423 Could you change to Debian 10?

ghost
ghost suggested changes Oct 9, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbui423 Suggested changes:

lib/ansible/config/base.yml Outdated Show resolved Hide resolved
test/integration/targets/interpreter_discovery_python/tasks/main.yml Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 9, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 10, 2019
johnbui423 and others added 2 commits October 11, 2019 15:06
@johnbui423
Update lib/ansible/config/base.yml
1e3ba5a 
Co-Authored-By: Oleg Kupriyanov <49687691+okupriyanov@users.noreply.github.com>
@johnbui423
Update test/integration/targets/interpreter_discovery_python/tasks/ma…
fe6e67f 
…in.yml

Co-Authored-By: Oleg Kupriyanov <49687691+okupriyanov@users.noreply.github.com>
@johnbui423 johnbui423 changed the title Default to python3 on Debian 9 Default to python3 on Debian 10 Oct 11, 2019
@sivel sivel requested a review from nitzmahone October 18, 2019 14:08
nitzmahone
nitzmahone approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is good, but will have to be in >= 2.10 only. I think it's too late to change the behavior for 2.9 (ie should not be backported).

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Oct 26, 2019
@sivel
Copy link
Member

sivel commented Nov 14, 2019

rebuild_merge

@sivel sivel merged commit db3994c into ansible:devel Nov 14, 2019
anshulbehl pushed a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
@johnbui423 @anshulbehl
Default to python3 on Debian 10 (ansible#63097)
3b2d9f6
@ansible ansible locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. python3 small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@johnbui423 @sivel @nitzmahone @bcoca @ansibot