Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kylin Linux Advanced Server Support #78232

Merged
merged 1 commit into from Jul 12, 2022

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Jul 11, 2022

SUMMARY

Detect os_family for Kylin Linux Advanced Server as 'RedHat', instead of 'Kylin Linux Advanced Server'.

Signed-off-by: Kay Yan kay.yan@daocloud.io

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/kylin_linux_advanced_server_distribution_support.yml
lib/ansible/module_utils/facts/system/distribution.py
test/units/module_utils/facts/system/distribution/fixtures/kylin_linux_advanced_server_v10.json

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 11, 2022
@yankay yankay force-pushed the Added-support-for-kylinOS branch from e7c91ef to 3a9a00c Compare July 11, 2022 07:11
@yankay
Copy link
Contributor Author

yankay commented Jul 11, 2022

The PR is helpful to the projects using ansible to support Kylin Linux. Like:

kubernetes-sigs/kubespray#9078

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 11, 2022
@yankay yankay force-pushed the Added-support-for-kylinOS branch from 33f2827 to c6e01d4 Compare July 11, 2022 08:02
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 11, 2022
@yankay yankay force-pushed the Added-support-for-kylinOS branch from c6e01d4 to 2483aa0 Compare July 11, 2022 10:29
@yankay
Copy link
Contributor Author

yankay commented Jul 12, 2022

HI @dsavineau, would you please review the code? Thank you very much.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2022
@mkrizek mkrizek merged commit 2e4b0fe into ansible:devel Jul 12, 2022
@yankay
Copy link
Contributor Author

yankay commented Jul 13, 2022

Thanks @mkrizek .

@ansible ansible locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants